Skip to content

[b/407765680] Better UX for dumper connector tasks failures due to la… #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sten1ee merged 2 commits into from
Apr 2, 2025
Merged

[b/407765680] Better UX for dumper connector tasks failures due to la… #841

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23bd01a
[b/407765680] Better UX for dumper connector tasks failures due to la…
sten1ee Apr 1, 2025
8e2b3fb
improve logs api usage
vladislav-sidorovich Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/TasksRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import com.google.edwmigration.dumper.application.dumper.task.TaskRunContextOps;
import com.google.edwmigration.dumper.application.dumper.task.TaskSetState;
import com.google.edwmigration.dumper.application.dumper.task.TaskState;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.sql.SQLException;
import java.time.Duration;
Expand Down Expand Up @@ -123,6 +124,9 @@ private void logProgress() {
PROGRESS_LOG.info(progressMessage);
}

private static final String ACCESS_CONTROL_EXCEPTION_MSG_SUFFIX =
".AccessControlException: SIMPLE authentication is not enabled. Available:[TOKEN, KERBEROS]";

private <T> T runTask(Task<T> task) throws MetadataDumperUsageException {
try {
CHECK:
Expand Down Expand Up @@ -152,10 +156,16 @@ private <T> T runTask(Task<T> task) throws MetadataDumperUsageException {
if (e instanceof MetadataDumperUsageException) throw (MetadataDumperUsageException) e;
if (e instanceof SQLException && e.getCause() instanceof MetadataDumperUsageException)
throw (MetadataDumperUsageException) e.getCause();
if (e instanceof IOException // is it a org.apache.hadoop.security.AccessControlException?
&& e.getMessage().endsWith(ACCESS_CONTROL_EXCEPTION_MSG_SUFFIX)) {
if (!task.handleException(e))
logger.warn("Task failed due to access denied: {}: {}", task, e.getMessage());
}
// TaskGroup is an attempt to get rid of this condition.
// We might need an additional TaskRunner / TaskSupport with an overrideable handleException
// method instead of this runTask() method.
if (!task.handleException(e)) logger.warn("Task failed: " + task + ": " + e, e);
else if (!task.handleException(e))
logger.warn("Task failed: {}: {}", task, e.getMessage(), e);
state.setTaskException(task, TaskState.FAILED, e);
try {
OutputHandle sink = context.newOutputFileHandle(task.getTargetPath() + ".exception.txt");
Expand All @@ -166,7 +176,7 @@ private <T> T runTask(Task<T> task) throws MetadataDumperUsageException {
"******************************",
String.valueOf(new DumperDiagnosticQuery(e).call())));
} catch (Exception f) {
logger.warn("Exception-recorder failed: " + f, f);
logger.warn("Exception-recorder failed: {}", f.getMessage(), f);
}
}
return null;
Expand Down