Skip to content

[OPS] clean-up logger usage #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladislav-sidorovich merged 1 commit into from
Aug 21, 2025
Merged

[OPS] clean-up logger usage #937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...r/app/src/main/java/com/google/edwmigration/dumper/application/dumper/MetadataDumper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,7 @@ private Path prepareOutputPath(
if (matcher.matches()) {
String bucket = matcher.group("bucket");
String path = matcher.group("path");
logger.debug(
String.format(
"Setting up CloudStorageFileSystem with bucket '%s' and path '%s'.", bucket, path));
logger.debug("Setting up CloudStorageFileSystem with bucket '{}' and path '{}'.", bucket, path);
CloudStorageFileSystem cloudStorageFileSystem =
closer.register(CloudStorageFileSystem.forBucket(bucket));
return cloudStorageFileSystem.getPath(path);
Expand Down Expand Up @@ -165,7 +163,7 @@ protected boolean run(@Nonnull Connector connector, @Nonnull ConnectorArguments
long outputFileLength = 0;
TaskSetState.Impl state = new TaskSetState.Impl();

logger.info("Using " + connector);
logger.info("Using connector: [{}]", connector);
SummaryPrinter summaryPrinter = new SummaryPrinter();
boolean requiredTaskSucceeded = false;

Expand All @@ -183,7 +181,7 @@ protected boolean run(@Nonnull Connector connector, @Nonnull ConnectorArguments
closer.register(FileSystems.newFileSystem(outputUri, fileSystemProperties));
OutputHandleFactory sinkFactory =
new FileSystemOutputHandleFactory(fileSystem, "/"); // It's required to be "/"
logger.debug("Target filesystem is " + sinkFactory);
logger.debug("Target filesystem is [{}]", sinkFactory);

Handle handle = closer.register(connector.open(arguments));

Expand Down
Loading