Fixes for Connector#validate #944
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateForConnectorcalled byAbstractSnowflakeConnector#validate. The methodvalidatehandles common checks for the data source, whilevalidateForConnectorhandles checks for a specific connector, e.g.snowflake-logs. This is done to ensure that a connector doesn't accidentally skip common validation.Nonnullto the param ofvalidate. We don't expectConnectorArgumentsto be null.validateDateRangenon-default. This method is not core connector functionality, it doesn't depend on the connector instance and it shouldn't be overridden. A static method fits better for the usage.validateDateRangeto make it less nested.