Skip to content

Conversation

@misolt
Copy link
Member

@misolt misolt commented Aug 26, 2025

  • Add a method validateForConnector called by AbstractSnowflakeConnector#validate. The method validate handles common checks for the data source, while validateForConnector handles checks for a specific connector, e.g. snowflake-logs. This is done to ensure that a connector doesn't accidentally skip common validation.
  • Add Nonnull to the param of validate. We don't expect ConnectorArguments to be null.
  • Make validateDateRange non-default. This method is not core connector functionality, it doesn't depend on the connector instance and it shouldn't be overridden. A static method fits better for the usage.
  • Simplify some checks in validateDateRange to make it less nested.

@misolt misolt marked this pull request as draft August 26, 2025 15:14
@misolt misolt marked this pull request as ready for review August 26, 2025 15:41
@misolt misolt merged commit d824897 into google:main Aug 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants