Rename warehouse-discovery-scripts to migration-discovery-scripts #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpiotrowski
requested review from
shevek-google and
vladislav-sidorovich
as code owners
misolt
approved these changes
Aug 27, 2025
Member
|
I suggest to follow YAGNI principle here. |
Member
|
The PR is still open and the renaming is very minor, so let's merger it to reduce number of open PRs. |
vladislav-sidorovich
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a proposal to rename
warehouse-discovery-scriptsdirectory tomigration-discovery-scripts. Existing directory name can be too restrictive if the content grows in the future.