[b/343209773] Improve ETA logging. #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lszydelko-google
requested review from
shevek-google and
vladislav-sidorovich
as code owners
Code Coverage Report
|
misolt
reviewed
Oct 9, 2025
dumper/app/src/test/java/com/google/edwmigration/dumper/application/dumper/TasksRunnerTest.java
Outdated
Show resolved
Hide resolved
misolt
reviewed
Oct 9, 2025
...p/src/test/java/com/google/edwmigration/dumper/application/dumper/DurationFormatterTest.java
Outdated
Show resolved
Hide resolved
misolt
reviewed
Oct 9, 2025
dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/TasksRunner.java
Outdated
Show resolved
Hide resolved
misolt
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new mechanic to better handle longer tasks. Since smaller tasks will take only a little time, and longer one will drag, there is another calculation of remaining time based only of last 10 tasks times. That will filter out the small tasks and take into considerations only the longest ones that are finished. Also there is a logic that takes maximum of old way and a new way of calculating ETA to prevent regression when only small amount of tasks are finished.
Moreover I increase threshold for smallest remaining time from 1 minute to 15 minutes.