Explicitly expose a set of build system dependencies #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new script, `manage_build_json.py`, which queries Bazel to determine the source files for the Emboss compiler and C++ runtime. The script generates a `build.json` file in the project root, which will serve as the source of truth for generating build helper files for other build systems. The script also adds support for verifying that `build.json` is in sync with the bazel build targets.
Adds a check to the `verify-pull-request` CI workflow to make sure that `build.json` is in sync with the bazel build targets.
Adds a `generate_build_files.py` script that is used to generate build files for use in bazel, cmake, and GN. Additionally a clean json file is added for more generic usage. These files are intended to be included in downstream build systems to explicitly list out the files required by embossc and the C++ runtime. The generated build files are included as well.
Add details on how to update `build.json` and generate the build files.
EricRahm
force-pushed
the
feature/build-helper-generation
branch
from
e47bec9 to
e2de64f
Compare
jasongraffius
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream users of
embosshave been hand-rolling a list of file dependencies needed to build with and useemboss. This PR adds a set of scripts to help generate a canonical file listbuild.jsonand then a set of generated build system files undergen/.Fixes #152
Fixes #172
Supersedes #171.