Skip to content

Ignore empty strings for StringConcatToTextBlock #5003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore empty strings for StringConcatToTextBlock #5003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/java/com/google/errorprone/bugpatterns/StringConcatToTextBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ && isSameType(getType(parent), state.getSymtab().stringType, state)) {
.filter(t -> t.kind().equals(Tokens.TokenKind.STRINGLITERAL))
.map(t -> t.stringVal())
.collect(toImmutableList());
if (strings.isEmpty()) {
return NO_MATCH;
}
boolean trailingNewline = getLast(strings).endsWith("\n");
// Only migrate if there are enough lines to make it worthwhile. Escaping the trailing newline
// slightly reduces the readability benefit of migrating, so require an extra line to make it
Expand Down