Skip to content

UnusedMethod not recognize annotated EndPoints #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+80 −0
Draft

UnusedMethod not recognize annotated EndPoints #5281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
.idea/uiDesigner.xml
.idea/vcs.xml
.idea/workspace.xml
.idea/checkstyle-idea.xml
.idea/palantir-java-format.xml

# bazel
bazel-bazel
Expand Down
78 changes: 78 additions & 0 deletions core/src/test/java/com/google/errorprone/bugpatterns/UnusedMethodTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,84 @@ private void bar() {}
.doTest();
}

@Test
public void exemptedByDefaultForRestController() {
helper
.addSourceLines(
"Foo.java",
"""
/*
* Copyright 2012-present the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package smoketest.test.web;

import smoketest.test.domain.User;
import smoketest.test.service.VehicleDetails;
import smoketest.test.service.VehicleIdentificationNumberNotFoundException;

import org.springframework.http.HttpStatus;
import org.springframework.http.MediaType;
import org.springframework.web.bind.annotation.ExceptionHandler;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.ResponseStatus;
import org.springframework.web.bind.annotation.RestController;

/**
* Controller to return vehicle information for a given {@link User}.
*
* @author Phillip Webb
*/
@RestController
public class UserVehicleController {

private final UserVehicleService userVehicleService;

public UserVehicleController(UserVehicleService userVehicleService) {
this.userVehicleService = userVehicleService;
}

@GetMapping(path = "/{username}/vehicle", produces = MediaType.TEXT_PLAIN_VALUE)
public String getVehicleDetailsText(@PathVariable String username) {
VehicleDetails details = this.userVehicleService.getVehicleDetails(username);
return details.getMake() + " " + details.getModel();
}

@GetMapping(path = "/{username}/vehicle", produces = MediaType.APPLICATION_JSON_VALUE)
public VehicleDetails VehicleDetailsJson(@PathVariable String username) {
return this.userVehicleService.getVehicleDetails(username);
}

@GetMapping(path = "/{username}/vehicle.html", produces = MediaType.TEXT_HTML_VALUE)
public String VehicleDetailsHtml(@PathVariable String username) {
VehicleDetails details = this.userVehicleService.getVehicleDetails(username);
String makeAndModel = details.getMake() + " " + details.getModel();
return "<html><body><h1>" + makeAndModel + "</h1></body></html>";
}

@ExceptionHandler
@ResponseStatus(HttpStatus.NOT_FOUND)
private void handleVinNotFound(VehicleIdentificationNumberNotFoundException ex) {
}

}
""")
.doTest();
}

@Test
public void suppressions() {
helper
Expand Down