Skip to content

Migrate R4AvroConverterCustomProfileTest to JUnit 5 with cross-platform support #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Shiva-code-code
Copy link

This pull request updates R4AvroConverterCustomProfileTest to use JUnit 5 (jupiter) instead of JUnit 4, while still keeping the original JUnit 4 dependency for backward compatibility with existing tests.

Key changes:

Switched from @BeforeClass and Assert.* to JUnit 5 equivalents (@BeforeAll, Assertions.*).

Updated the resource path handling to use URI and Paths.get() to ensure compatibility across both Windows and Unix-based systems.

No business logic or assertion logic was changed—just a migration of syntax and setup.

Tested locally on Windows with mvn test, and everything runs as expected.
Open to feedback or changes if anything needs to be adjusted.xxx

Copy link

google-cla bot commented May 1, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Shiva-code-code Shiva-code-code force-pushed the migrate-junit5-custom-profile-test branch from 05450a6 to 2870e8f Compare May 1, 2025 05:10
@chandrashekar-s
Copy link
Collaborator

@Shiva-code-code if this change is ready for review, then can you please assign the reviewer, either @bashir2 or myself? Also, since this is your first contribution to the repo, can you please look at the comment made by the @google-cla bot in this PR.

@Shiva-code-code
Copy link
Author

Hi @chandrashekar-s, thanks for the follow-up. I’ve signed the CLA and the PR is now ready for review. Since I don’t have permission to assign reviewers, tagging you here as requested. Let me know if anything needs adjustment!

@chandrashekar-s chandrashekar-s self-requested a review May 16, 2025 04:57
@chandrashekar-s
Copy link
Collaborator

Thanks @Shiva-code-code for the update, I will have a look and share my feedback soon.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.80%. Comparing base (0cd9c1f) to head (16f6400).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1362      +/-   ##
============================================
- Coverage     50.28%   46.80%   -3.49%     
+ Complexity      698      666      -32     
============================================
  Files            90       90              
  Lines          5803     5803              
  Branches        798      798              
============================================
- Hits           2918     2716     -202     
- Misses         2587     2800     +213     
+ Partials        298      287      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants