Enforce Quality Gates for Java and Python sub projects on CI #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1543 +/- ##
============================================
+ Coverage 46.61% 46.73% +0.11%
- Complexity 678 684 +6
============================================
Files 90 90
Lines 5886 5889 +3
Branches 834 834
============================================
+ Hits 2744 2752 +8
+ Misses 2827 2822 -5
Partials 315 315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bashir2
reviewed
Dec 23, 2025
Collaborator
bashir2
left a comment
bashir2
left a comment
There was a problem hiding this comment.
Thanks @ndegwamartin for the changes; just a few minor suggestions/questions.
bunsen/bunsen-avro/src/main/java/com/cerner/bunsen/avro/converters/DefinitionToAvroVisitor.java
Show resolved
Hide resolved
bunsen/bunsen-avro/src/test/java/com/cerner/bunsen/avro/R4AvroConverterUsCoreTest.java
Show resolved
Hide resolved
pipelines/batch/src/main/java/com/google/fhir/analytics/HapiRowDescriptor.java
Show resolved
Hide resolved
pipelines/controller/src/main/java/com/google/fhir/analytics/PipelineManager.java
Outdated
Show resolved
Hide resolved
bashir2
approved these changes
Dec 23, 2025
Collaborator
bashir2
left a comment
bashir2
left a comment
There was a problem hiding this comment.
Thanks @ndegwamartin please feel free to merge after addressing the remaining comments below.
bunsen/bunsen-avro/src/main/java/com/cerner/bunsen/avro/converters/DefinitionToAvroVisitor.java
Show resolved
Hide resolved
pipelines/controller/src/main/java/com/google/fhir/analytics/PipelineManager.java
Outdated
Show resolved
Hide resolved
- Reverts lazy logging for main.py - Disables lazy logging check in pylint configuration - Refactors get current time to use static helper method - Adds unit tests for PipelineManager class
ndegwamartin
force-pushed
the
enable-ci-gates
branch
from
716b7e9 to
5991c60
Compare
-Fix pylint warning
bashir2
reviewed
Jan 13, 2026
pipelines/controller/src/main/java/com/google/fhir/analytics/DwhFilesManager.java
Outdated
Show resolved
Hide resolved
pipelines/controller/src/test/java/com/google/fhir/analytics/PipelineManagerTest.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Resolves #1541
E2E test
TESTED:
Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.
Checklist: I completed these to help reviewers :)
I have read and will follow the
review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review
Java and
Python style guides.
My IDE is configured to follow the Google
code styles.
No? Unsure? ->
configure your IDE.
I have added tests to cover my changes. (If you refactored existing
code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
If I made any Python code changes, I ran
black .,pylint .andpyright. right before creating this pull request and added allformatting changes to my commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master