External Texture implementation for Vulkan #8488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poweifeng
reviewed
Mar 4, 2025
| } | ||
| } | ||
|
|
||
| TextureUsage mapToFilamentUsage(unsigned int usage, TextureFormat format) noexcept { |
There was a problem hiding this comment.
Are you going to wait for the consolidation of these methods for GL/Vulkan?
|
|
||
| return format; | ||
| } | ||
|
|
||
| void getVKFormatAndUsage(const AHardwareBuffer_Desc& desc, VkFormat& format, |
There was a problem hiding this comment.
now that we're passing in a non-reference param at the end, maybe it's a good time to refactor. Would you mind having this return a std::pair<VkFormat, VkImageUsageFlags>?
filament/backend/include/backend/platforms/VulkanPlatformAndroid.h
Outdated
Show resolved
Hide resolved
rafadevai
force-pushed
the
vulkan_external_image2
branch
from
579983c to
3b6fe6a
Compare
Add support for the new createTextureExternalImage2R API instead of createTextureExternalImageR. Add the support to import AHardwareBuffer objects into Vulkan in Android.
rafadevai
force-pushed
the
vulkan_external_image2
branch
from
3b6fe6a to
a1c30c8
Compare
poweifeng
approved these changes
Mar 7, 2025
|
|
||
| #include <android/hardware_buffer.h> | ||
|
|
||
| namespace filament::backend::fvkandroid { |
There was a problem hiding this comment.
nit: why do we need another namespace at all?
Is it to avoid createExternalImage conflicting?
And why is createExternalImage UTILS_PUBLIC ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the new createTextureExternalImage2R API instead of createTextureExternalImageR.
Add the support to import AHardwareBuffer objects
into Vulkan in Android.