Ebridgewater/tint conversion validation #8494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridgewaterrobbie
force-pushed
the
ebridgewater/tintConversionValidation
branch
from
2cbff04 to
9173c95
Compare
bridgewaterrobbie
changed the base branch from
main
to
rbridgewater/configMaxSpecConstantWgslFix
bridgewaterrobbie
force-pushed
the
rbridgewater/configMaxSpecConstantWgslFix
branch
from
a945508 to
fcbe436
Compare
bridgewaterrobbie
force-pushed
the
ebridgewater/tintConversionValidation
branch
from
9173c95 to
6a0d74d
Compare
Base automatically changed from
rbridgewater/configMaxSpecConstantWgslFix
to
main
March 7, 2025 00:28
bridgewaterrobbie
force-pushed
the
ebridgewater/tintConversionValidation
branch
from
6a0d74d to
07b16d0
Compare
bridgewaterrobbie
force-pushed
the
ebridgewater/tintConversionValidation
branch
from
d12eb96 to
c42be3e
Compare
…t pass the test due to the webgpu build failing or similar
bridgewaterrobbie
force-pushed
the
ebridgewater/tintConversionValidation
branch
from
c42be3e to
5c9e254
Compare
AndyHovingh
reviewed
Mar 7, 2025
| @@ -196,6 +197,11 @@ static constexpr const char* shaderLanguageToString(ShaderLanguage shaderLanguag | |||
| return "MSL"; | |||
| case ShaderLanguage::METAL_LIBRARY: | |||
| return "Metal precompiled library"; | |||
| case ShaderLanguage::WGSL: | |||
| return "WebGPU"; | |||
There was a problem hiding this comment.
Agreed, will fix
AndyHovingh
reviewed
Mar 7, 2025
| break; | ||
| break; | ||
| case ChunkType::MaterialWgsl: | ||
| text << "Wgsl precompiled shader libraries:" << endl; |
There was a problem hiding this comment.
nit: WGSL to be consistent with acronyms above?
There was a problem hiding this comment.
Not sure what you mean here- the case sensitivity?
There was a problem hiding this comment.
Yeah the case sensitivity, again nit-picking, not really important all, but I just mean "GLSL..", "ESSL1...", "WGSL..." (instead of "Wgsl..."). (Vulkan and Metal are not acronyms, as far as I am aware). Feel free to take or leave it, just small observation.
bridgewaterrobbie
assigned bridgewaterrobbie, pixelflinger and poweifeng and unassigned pixelflinger and poweifeng
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the tint conversion codepath to be run when passed via matc.
Add unit test for tint conversion.
Run this new unit test as part of presubmit.