Add a way to pass a transform matrix along with Stream::setAcquiredImage #8496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…param for the associated transform matrix
…to track if the ubo needs to be updated.
… path can also update the transform in the shader.
pixelflinger
requested changes
Mar 6, 2025
Replace cmakelist content with few set and includes Add the patch file to convert dawn shared to static lib Thanks Robbie Bridgewater for helping out with this implementation
Introduce FILAMENT_SUPPORTS_WEBGPU flag to be used for webgpu support. Add -W option to build.sh for webgpu support compilation from build script. Thanks Andy Hovingh for helping out with this implementation
Introduce Enums to support WebGPU. Start to use header files from dawn.
Updated the `terminate` function to correct resource cleanup. Changed `mUsedStages` to `mUsedImages` and `mFreeStages` to `mFreeImages` to ensure proper memory management during termination.
* Enable fgviewer for the users * Fix incorrect position * Update * Support remote debug server * Enable fgviewer on android * Link and include fgviewer_resources * Adjust js to show untitled view
pixelflinger
requested changes
Mar 7, 2025
pixelflinger
approved these changes
Mar 10, 2025
poweifeng
approved these changes
Mar 10, 2025
z3moon
pushed a commit
that referenced
this pull request
Mar 10, 2025
…age (#8496) BUGS=[399959254] --------- Co-authored-by: Syed Idris Shah <[email protected]> Co-authored-by: Haneul Kim <[email protected]> Co-authored-by: Powei Feng <[email protected]> Co-authored-by: Doris Wu <[email protected]> Co-authored-by: Mathias Agopian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #8493
Streams in OpenGL are either backed by SurfaceTexture (Native in filament) or ImageReader (Acquired in filament). SurfaceTextures have a transform attached to the image that's updated every frame but have to be read from the GL thread. The ImageReader path has the same transform but is read from the main thread. The transform in the SurfaceTexture path can be optionally requested in the shader (see #8490). This PR adds a way for the ImageReader path to also update this transform.