Add getter functions for settings to build ColorGrading object #8699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poweifeng
approved these changes
May 6, 2025
filament/src/details/ColorGrading.h
Outdated
| @@ -51,6 +51,8 @@ class FColorGrading : public ColorGrading { | |||
| uint32_t mDimension; | |||
| bool mIsOneDimensional; | |||
| bool mIsLDR; | |||
|
|
|||
| void initializeSettings(Settings& settings, const Builder& builder) noexcept; | |||
There was a problem hiding this comment.
static method?
nit: can you make settings the second param? Typically the "output" is at the end of the list of parameters.
There was a problem hiding this comment.
Thanks for your suggestion, and I now incorporated that to my change.
dkasuga
force-pushed
the
dk/colorgrading-properties-getter
branch
from
2971fd3 to
1fef472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ColorGrading is created using a builder API, but there's no way to retrieve the settings that were used to build it after the fact. As the most simple and robust solution, this change make the
ColorGradingobject storing its creation parameters internally and providing their getter functions.This change also involves changing changing the interface of the existing
ToneMappersetter of the builder so that it takes tone mapper asshared_ptrinstead of the raw pointer. For JNI function impl, to avoid the risk of the double free between C++ codes and JVM GC, theToneMapperinstance is just copied and passed.FIXES=[364901658]