Skip to content

Allow listening to primary ScrollController #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow listening to primary ScrollController #506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e185c
Allow listening to primary ScrollController
Lootwig Dec 12, 2023
a76bd71
fix: missing brace, remove redundant non-null assertion
Lootwig Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/scrollable_positioned_list/lib/src/scrollable_positioned_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class ScrollablePositionedList extends StatefulWidget {
this.addAutomaticKeepAlives = true,
this.addRepaintBoundaries = true,
this.minCacheExtent,
this.controllerListener,
}) : assert(itemCount != null),
assert(itemBuilder != null),
itemPositionsNotifier = itemPositionsListener as ItemPositionsNotifier?,
Expand Down Expand Up @@ -87,13 +88,18 @@ class ScrollablePositionedList extends StatefulWidget {
this.addAutomaticKeepAlives = true,
this.addRepaintBoundaries = true,
this.minCacheExtent,
this.controllerListener,
}) : assert(itemCount != null),
assert(itemBuilder != null),
assert(separatorBuilder != null),
itemPositionsNotifier = itemPositionsListener as ItemPositionsNotifier?,
scrollOffsetNotifier = scrollOffsetListener as ScrollOffsetNotifier?,
super(key: key);

/// Optional listener for the primary scroll controller.
/// Called once after first frame.
final void Function(ScrollController controller)? controllerListener;

/// Number of items the [itemBuilder] can produce.
final int itemCount;

Expand Down Expand Up @@ -345,8 +351,12 @@ class _ScrollablePositionedListState extends State<ScrollablePositionedList>
if (!_isTransitioning |
(widget.scrollOffsetNotifier?.recordProgrammaticScrolls ?? false)) {
widget.scrollOffsetNotifier?.changeController.add(offsetChange);
widget.controllerListener?.call(primary.scrollController);
}
});
WidgetsBinding.instance.addPostFrameCallback((_) {
widget.controllerListener?.call(primary.scrollController);
});
}

@override
Expand Down