Skip to content

Correct Iansui's metadata #9163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

bestpika
Copy link

@bestpika bestpika commented Mar 6, 2025

All modifications to the writing of this font are based on the standards of the "Ministry of Education of Taiwan," so it should be categorized as Taiwanese Chinese rather than Hong Kong Chinese.

This font was modified by a Taiwanese based on Klee One, not from Hong Kong.
Copy link

google-cla bot commented Mar 6, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bestpika
Copy link
Author

bestpika commented Mar 8, 2025

It seems that after signing the CLA, a rescan is needed, it's done.

@m4rc1e m4rc1e requested a review from aaronbell March 19, 2025 14:17
@aaronbell
Copy link
Collaborator

@m4rc1e I think all the TC fonts were changed to the Hong Kong subset, but honestly I don’t know why. I figured it was something to do with the GF backend systems, but I think it has other effects, like with how these fonts are showing up in workspace. I’m not even sure why we can only assign one CJK subset…

@chrissimpkins

@chrissimpkins
Copy link
Collaborator

@emmamarichal is this proposal now outdated based on the latest changes in Iansui?

@emmamarichal
Copy link
Collaborator

Yes, it has been done here: https://github.com/google/fonts/pull/9296/files

@chrissimpkins
Copy link
Collaborator

Thanks for the prompt to make this change @bestpika

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants