-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Libertinus Keyboard: Version 7.051;RELEASE added #9301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Taken from the upstream repo https://github.com/googlefonts/libertinus at commit googlefonts/libertinus@88dfbb0. Resolves #12
FontBakery reportfontbakery version: 0.13.2 Check results[29] LibertinusKeyboard-Regular.ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs. case_mapping
🔥 FAIL Font contains glyphs for whitespace characters? whitespace_glyphs
🔥 FAIL Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
🔥 FAIL Copyright notices match canonical pattern in fonts googlefonts/font_copyright
"Copyright 2020 The Familyname Project Authors (git url)" But instead we have got: "???." [code: bad-notice-format]🔥 FAIL Check Google Fonts glyph coverage. googlefonts/glyph_coverage
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]🔥 FAIL Check font follows the Google Fonts vertical metric schema googlefonts/vertical_metrics
|
ofl/libertinuskeyboard/LibertinusKeyboard-Regular.ttf | |
---|---|
Dehinted Size | 125.0kb |
Hinted Size | 199.7kb |
Increase | 74.7kb |
Change | 59.7 % |
ℹ️ INFO Font contains all required tables? required_tables
- ℹ️ INFO
This font contains the following optional tables:
- cvt
- fpgm
- loca
- prep
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges]ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
- ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 7.051;RELEASE']
[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
- ℹ️ INFO
All of the fonts lack a STAT table.
[code: summary]
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 6 | 17 | 62 | 7 | 144 | 0 |
0% | 0% | 3% | 7% | 26% | 3% | 61% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
FontBakery reportfontbakery version: 0.13.2 Check results[29] LibertinusKeyboard-Regular.ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs. case_mapping
🔥 FAIL Font contains glyphs for whitespace characters? whitespace_glyphs
🔥 FAIL Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
🔥 FAIL Copyright notices match canonical pattern in fonts googlefonts/font_copyright
"Copyright 2020 The Familyname Project Authors (git url)" But instead we have got: "???." [code: bad-notice-format]🔥 FAIL Check Google Fonts glyph coverage. googlefonts/glyph_coverage
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]🔥 FAIL Check font follows the Google Fonts vertical metric schema googlefonts/vertical_metrics
|
ofl/libertinuskeyboard/LibertinusKeyboard-Regular.ttf | |
---|---|
Dehinted Size | 125.0kb |
Hinted Size | 199.7kb |
Increase | 74.7kb |
Change | 59.7 % |
ℹ️ INFO Font contains all required tables? required_tables
- ℹ️ INFO
This font contains the following optional tables:
- cvt
- fpgm
- loca
- prep
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges]ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
- ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 7.051;RELEASE']
[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
- ℹ️ INFO
All of the fonts lack a STAT table.
[code: summary]
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 6 | 17 | 62 | 7 | 144 | 0 |
0% | 0% | 3% | 7% | 26% | 3% | 61% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
We should have a glyph for uni00A0 (nbspace). Since nbspace and space have the same adv width, you could always just double map the space. |
Note that I don't have access to the sources but only hotfixing binaries. Of course it can be achieved. Let me know how important this fix is to you given these circumstances. |
Taken from the upstream repo https://github.com/googlefonts/libertinus at commit googlefonts/libertinus@88dfbb0.
Resolves #12
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectstags
are added for NEW FONTSprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.