Skip to content

Agbalumo: Version 2.000; ttfautohint (v1.8.4.7-5d5b) added #9344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yanone
Copy link
Collaborator

@yanone yanone commented Apr 15, 2025

Taken from the upstream repo https://github.com/SorkinType/Agbalumo at commit SorkinType/Agbalumo@4b00209.

Resolves #8913

PR Checklist:

  • tags are added for NEW FONTS
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”

@yanone yanone added I Font Upgrade II African Mostly west african non-latin and African indigenous scripts II Commissioned Commissioned project to do labels Apr 15, 2025

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

FontBakery report

fontbakery version: 0.13.2

Check results

[23] Agbalumo-Regular.ttf
🔥 FAIL Ensure the font supports case swapping for all its glyphs. case_mapping
  • 🔥 FAIL

    The following glyphs lack their case-swapping counterparts:

Glyph present in the font Missing case-swapping counterpart
U+019E: LATIN SMALL LETTER N WITH LONG RIGHT LEG U+0220: LATIN CAPITAL LETTER N WITH LONG RIGHT LEG
U+0223: LATIN SMALL LETTER OU U+0222: LATIN CAPITAL LETTER OU
U+024B: LATIN SMALL LETTER Q WITH HOOK TAIL U+024A: LATIN CAPITAL LETTER SMALL Q WITH HOOK TAIL
U+026C: LATIN SMALL LETTER L WITH BELT U+A7AD: LATIN CAPITAL LETTER L WITH BELT
U+1E29: LATIN SMALL LETTER H WITH CEDILLA U+1E28: LATIN CAPITAL LETTER H WITH CEDILLA
U+1E65: LATIN SMALL LETTER S WITH ACUTE AND DOT ABOVE U+1E64: LATIN CAPITAL LETTER S WITH ACUTE AND DOT ABOVE
U+1E67: LATIN SMALL LETTER S WITH CARON AND DOT ABOVE U+1E66: LATIN CAPITAL LETTER S WITH CARON AND DOT ABOVE
U+2184: LATIN SMALL LETTER REVERSED C U+2183: ROMAN NUMERAL REVERSED ONE HUNDRED
U+2C61: LATIN SMALL LETTER L WITH DOUBLE BAR U+2C60: LATIN CAPITAL LETTER L WITH DOUBLE BAR
U+2C66: LATIN SMALL LETTER T WITH DIAGONAL STROKE U+023E: LATIN CAPITAL LETTER T WITH DIAGONAL STROKE
U+A727: LATIN SMALL LETTER HENG U+A726: LATIN CAPITAL LETTER HENG
U+A741: LATIN SMALL LETTER K WITH STROKE U+A740: LATIN CAPITAL LETTER K WITH STROKE
U+A7A9: LATIN SMALL LETTER S WITH OBLIQUE STROKE U+A7A8: LATIN CAPITAL LETTER S WITH OBLIQUE STROKE
U+AB53: LATIN SMALL LETTER CHI U+A7B3: LATIN CAPITAL LETTER CHI
[code: missing-case-counterparts]
🔥 FAIL METADATA.pb: Designers are listed correctly on the Google Fonts catalog? googlefonts/metadata/designer_profiles
  • 🔥 FAIL

    Designer Yikunoamlak Ayalew still does not have an avatar image. Please provide one.


    [code: missing-avatar]

  • ⚠️ WARN

    It seems that Raphael Alẹ́gbẹ́lẹ́yẹ̀ is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

🔥 FAIL Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
  • 🔥 FAIL

    GF_Phonetics_SinoExt glyphset:

FAIL messages Languages
Mandatory orthography codepoints:
The following base characters are missing from the font: ᵃ, ᵓ, ᵉ, ⁱ, ᶶ, ᵒ, ᶤ, ᵋ teo_Latn (Teso)
Mandatory orthography codepoints:
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀'
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach uni0302 to uni0259 when shaping the text 'ə̂'
Shaper didn't attach uni030C to uni0259 when shaping the text 'ə̌' nfu_Latn (Mfumte), bax_Latn (Bamun (Latin)), bfd_Latn (Bafut) and bbj_Latn (Ghomala)
Mandatory orthography codepoints:
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀'
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach uni0327 to uni0259 when shaping the text 'ə̧'
Shaper didn't attach uni0327 to uni0259 when shaping the text 'ə̧̀'
Shaper didn't attach uni0327 to uni0259 when shaping the text 'ə̧́' dur_Latn (Dii)
Mandatory orthography codepoints:
Shaper didn't attach tildecomb to uni026A when shaping the text 'ɪ̃'
Shaper didn't attach tildecomb to uniA7B7 when shaping the text 'ꞷ̃' kzc_Latn (Bondoukou Kulango)
Mandatory orthography codepoints:
Shaper didn't attach gravecomb to uni01DD when shaping the text 'ǝ̀'
Shaper didn't attach acutecomb to uni01DD when shaping the text 'ǝ́'
Shaper didn't attach uni0302 to uni01DD when shaping the text 'ǝ̂'
Shaper didn't attach tildecomb to uni01DD when shaping the text 'ǝ̃'
Shaper didn't attach tildecomb to uni01DD when shaping the text 'ǝ̃̀'
Shaper didn't attach tildecomb to uni01DD when shaping the text 'ǝ̃́'
Shaper didn't attach tildecomb to uni01DD when shaping the text 'ǝ̃̂' dnj_Latn_LR (Liberian Dan)
Mandatory orthography codepoints:
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀' nnw_Latn (Southern Nuni)
Mandatory orthography codepoints:
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀'
Shaper didn't attach uni030C to uni0259 when shaping the text 'ə̌'
Shaper didn't attach uni0304 to uni0259 when shaping the text 'ə̄' fmp_Latn (Fe’fe’)
Mandatory orthography codepoints:
The following base characters are missing from the font: ɤ̂, ɤ̋, ɤ, ɤ̏, ɤ́, ɤ̄, ɤ̀
Shaper didn't attach uni030F to uniA7CB when shaping the text 'Ɤ̏'
Shaper didn't attach gravecomb to uniA7CB when shaping the text 'Ɤ̀'
Shaper didn't attach uni0304 to uniA7CB when shaping the text 'Ɤ̄'
Shaper didn't attach acutecomb to uniA7CB when shaping the text 'Ɤ́'
Shaper didn't attach uni030B to uniA7CB when shaping the text 'Ɤ̋'
Shaper didn't attach uni0302 to uniA7CB when shaping the text 'Ɤ̂' dnj_Latn (Dan)
Mandatory orthography codepoints:
Shaper didn't attach acutecomb to uni01DD when shaping the text 'ǝ́' ksf_Latn (Bafia)
Mandatory orthography codepoints:
Shaper didn't attach acutecomb to uni01DD when shaping the text 'ǝ́'
Shaper didn't attach gravecomb to uni01DD when shaping the text 'ǝ̀'
Shaper didn't attach uni0302 to uni01DD when shaping the text 'ǝ̂' blo_Latn (Anii)
Mandatory orthography codepoints:
Shaper didn't attach gravecomb to uni01DD when shaping the text 'ǝ̀'
Shaper didn't attach acutecomb to uni01DD when shaping the text 'ǝ́'
Shaper didn't attach tildecomb to uni01DD when shaping the text 'ǝ̃'
Shaper didn't attach tildecomb to uni01DD when shaping the text 'ǝ̃̀'
Shaper didn't attach tildecomb to uni01DD when shaping the text 'ǝ̃́' tuz_Latn (Turka)
Mandatory orthography codepoints:
Shaper didn't attach uni0327 to uni0259 when shaping the text 'ə̧'
Shaper didn't attach uni0327 to uni0259 when shaping the text 'ə̧́'
Shaper didn't attach uni0327 to uni0259 when shaping the text 'ə̧̀'
Shaper didn't attach uni0327 to uni0259 when shaping the text 'ə̧̂' vut_Latn (Vute)
Mandatory orthography codepoints:
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀' gnd_Latn (Zulgo-Gemzek) and mgo_Latn (Metaʼ)
Mandatory orthography codepoints:
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀'
Shaper didn't attach uni0302 to uni0259 when shaping the text 'ə̂'
Shaper didn't attach uni030C to uni0259 when shaping the text 'ə̌' ewo_Latn (Ewondo)
Mandatory orthography codepoints:
Shaper didn't attach uni0302 to uni0259 when shaping the text 'ə̂'
Shaper didn't attach uni0308 to uni0259 when shaping the text 'ə̈' ksp_Latn (Kabba) and lnl_Latn (South Central Banda)
Mandatory orthography codepoints:
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀'
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́' bum_Latn (Bulu) and eto_Latn (Eton, Cameroon)
Mandatory orthography codepoints:
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach uni0304 to uni0259 when shaping the text 'ə̄' ybb_Latn (Yemba) and mwm_Latn (Sar)
Mandatory orthography codepoints:
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀'
Shaper didn't attach uni0302 to uni0259 when shaping the text 'ə̂'
Shaper didn't attach uni030C to uni0259 when shaping the text 'ə̌' byv_Latn (Medumba) and mnf_Latn (Mundani)
Mandatory orthography codepoints:
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach uni0302 to uni0259 when shaping the text 'ə̂'
Shaper didn't attach uni030C to uni0259 when shaping the text 'ə̌' mcp_Latn (Makaa)
Mandatory orthography codepoints:
Shaper didn't attach tildecomb to uni01DD when shaping the text 'ǝ̃' lob_Latn (Lobi)
Mandatory orthography codepoints:
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach uni0302 to uni0259 when shaping the text 'ə̂' etu_Latn (Ejagham)
Mandatory orthography codepoints:
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀'
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach uni0302 to uni0259 when shaping the text 'ə̂' gkp_Latn (Kpelle, Guinea)
Mandatory orthography codepoints:
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀'
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach uni0330 to uni0259 when shaping the text 'ə̰'
Shaper didn't attach uni0330 to uni0259 when shaping the text 'ə̰̀'
Shaper didn't attach uni0330 to uni0259 when shaping the text 'ə̰́' mge_Latn (Mango)
Mandatory orthography codepoints:
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach uni0304 to uni0259 when shaping the text 'ə̄'
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀' wok_Latn (Longto)
Mandatory orthography codepoints:
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach uni0330 to uni0259 when shaping the text 'ə̰' sba_Latn (Ngambay)
Mandatory orthography codepoints:
The following base characters are missing from the font: ɤ̀, ɤ́, ɤ̂, ɤ
Shaper didn't attach acutecomb to uniA7CB when shaping the text 'Ɤ́'
Shaper didn't attach uni0302 to uniA7CB when shaping the text 'Ɤ̂'
Shaper didn't attach gravecomb to uniA7CB when shaping the text 'Ɤ̀' gov_Latn (Goo)
Mandatory orthography codepoints:
The following base characters are missing from the font: t͟h, T͟H
The following mark characters are missing from the font: ͟ udu_Latn (Uduk)
Mandatory orthography codepoints:
Shaper didn't attach acutecomb to uni01DD when shaping the text 'ǝ́'
Shaper didn't attach uni0302 to uni01DD when shaping the text 'ǝ̂'
Shaper didn't attach uni030C to uni01DD when shaping the text 'ǝ̌'
Shaper didn't attach uni0304 to uni01DD when shaping the text 'ǝ̄' nmg_Latn (Kwasio)
Mandatory orthography codepoints:
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́' gvl_Latn (Gulay)
Mandatory orthography codepoints:
The following base characters are missing from the font: ˀ giz_Latn (Southern Giziga)
Mandatory orthography codepoints:
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀'
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach uni030C to uni0259 when shaping the text 'ə̌'
Shaper didn't attach uni0302 to uni0259 when shaping the text 'ə̂' lee_Latn (Lyélé)
Mandatory orthography codepoints:
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀'
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach uni030C to uni0259 when shaping the text 'ə̌'
Shaper didn't attach uni0308 to uni0259 when shaping the text 'ə̈' sbd_Latn (Southern Samo)
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: ſ de_Latn (German) and fr_Latn (French)
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: ƃ
The following auxiliary characters are missing from the font: Ƃ dnj_Latn_LR (Liberian Dan) and lom_Latn (Loma, Liberia)
Auxiliary orthography codepoints:
Shaper didn't attach uni0304 to uni0259 when shaping the text 'ə̄' bax_Latn (Bamun (Latin))
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: ⓐ
The following auxiliary characters are missing from the font: Ⓐ kib_Latn (Koalib)
Auxiliary orthography codepoints:
Shaper didn't attach uni0308 to uni0259 when shaping the text 'ə̈' ybb_Latn (Yemba)
Auxiliary orthography codepoints:
Shaper didn't attach uni0328 to uni0259 when shaping the text 'ə̨'
Shaper didn't attach uni0328 to uni018F when shaping the text 'Ə̨'
Shaper didn't attach uni0328 to uni0259 when shaping the text 'ə̨́'
Shaper didn't attach acutecomb to uni0328 when shaping the text 'ə̨́'
Shaper didn't attach uni0328 to uni018F when shaping the text 'Ə̨́'
Shaper didn't attach uni0328 to uni025B when shaping the text 'ɛ̨'
Shaper didn't attach uni0328 to uni0190 when shaping the text 'Ɛ̨'
Shaper didn't attach uni0328 to uni025B when shaping the text 'ɛ̨́'
Shaper didn't attach uni0328 to uni0190 when shaping the text 'Ɛ̨́'
Shaper didn't attach uni0328 to uni0254 when shaping the text 'ɔ̨'
Shaper didn't attach uni0328 to uni0186 when shaping the text 'Ɔ̨'
Shaper didn't attach uni0328 to uni0254 when shaping the text 'ɔ̨́'
Shaper didn't attach uni0328 to uni0186 when shaping the text 'Ɔ̨́' gkp_Latn (Kpelle, Guinea)
Auxiliary orthography codepoints:
Shaper didn't attach acutecomb to uni0259 when shaping the text 'ə́'
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀'
Shaper didn't attach uni0304 to uni0259 when shaping the text 'ə̄' kyq_Latn (Kenga)
Auxiliary orthography codepoints:
Shaper didn't attach uni0304 to uni0259 when shaping the text 'ə̄'
Shaper didn't attach uni0330 to uni0259 when shaping the text 'ə̰̄' mge_Latn (Mango)
Auxiliary orthography codepoints:
Shaper didn't attach uni1DC6 to uni0196 when shaping the text 'Ɩ᷆' tcd_Latn (Tafi)
Auxiliary orthography codepoints:
Shaper didn't attach acutecomb to uni01DD when shaping the text 'ǝ́'
Shaper didn't attach uni0330 to uni01DD when shaping the text 'ǝ̰' sba_Latn (Ngambay)
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: ˀ mfd_Latn (Mendankwe-Nkwen)
Auxiliary orthography codepoints:
Shaper didn't attach gravecomb to uni0259 when shaping the text 'ə̀' gvl_Latn (Gulay)
[code: warning-language-shaping]
⚠️ WARN Check if each glyph has the recommended amount of contours. contour_count
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: y	Contours detected: 2	Expected: 1
  • Glyph name: AE Contours detected: 3 Expected: 2

  • Glyph name: yacute Contours detected: 3 Expected: 2

  • Glyph name: ydieresis Contours detected: 4 Expected: 3

  • Glyph name: lslash Contours detected: 2 Expected: 1

  • Glyph name: OE Contours detected: 3 Expected: 2

  • Glyph name: Tbar Contours detected: 2 Expected: 1

  • Glyph name: ycircumflex Contours detected: 3 Expected: 2

  • Glyph name: Uhorn Contours detected: 2 Expected: 1

  • Glyph name: uni01B4 Contours detected: 2 Expected: 1

  • 53 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Ensure files are not too large. file_size
  • ⚠️ WARN

    Font file is 1.6Mb; ideally it should be less than 1.0Mb


    [code: large-font]
⚠️ WARN Check math signs have the same width. math_signs_width
  • ⚠️ WARN

    The most common width is 556 among a set of 2 math glyphs.
    The following math glyphs have a different width, though:

Width = 554: plus

Width = 515: less

Width = 521: greater

Width = 565: logicalnot

Width = 579: plusminus

Width = 541: multiply

Width = 548: divide, minus

Width = 546: approxequal

Width = 502: lessequal

Width = 506: greaterequal

[code: width-outliers]
⚠️ WARN Ensure Stylistic Sets have description. stylisticset_description
  • ⚠️ WARN

    The stylistic set ss06 lacks a description string on the 'name' table.


    [code: missing-description]
⚠️ WARN Check font contains no unreachable glyphs unreachable_glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- M_gravecomb

- NumberStep2

- acutecomb.narrow

- ampersand.001

- ampersand.003

- ampersand.004

- ampersand.005

- capslash_part.

- dotbelowcomb.case.001

- fullstopethiopic.alt

- 26 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unreachable-glyphs]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets. googlefonts/article/images
  • ⚠️ WARN

    Family metadata at ofl/agbalumo does not have an article.


    [code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, tifinagh, cherokee, math
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: canadian-aboriginal, tifinagh, malayalam, syriac, old-permic, tai-le, duployan, hebrew, coptic, todhri, math
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+030D COMBINING VERTICAL LINE ABOVE: try adding sunuwar 80 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic-ext, ethiopic, latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak. googlefonts/description/eof_linebreak
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. soft_dotted
  • ⚠️ WARN

    The dot of soft dotted characters should disappear in other cases, for example: ɉ̀ ɉ́ ɉ̂ ɉ̃ ɉ̄ ɉ̆ ɉ̇ ɉ̈ ɉ̉ ɉ̊ ɉ̋ ɉ̌ ɉ̍ ɉ̏ ɉ̐ ɉ̑ ɉ̒ ɉ̓ ɉ᷄ ɉ᷅


    [code: soft-dotted]
⚠️ WARN Do outlines contain any jaggy segments? outline_jaggy_segments
  • ⚠️ WARN

    The following glyphs have jaggy segments:

* Eng.loclNSM: B<<392.5,483.0>-<431.0,369.0>-<454.0,212.0>>/L<<454.0,212.0>--<458.0,292.0>> = 11.196769743469542

* h (U+0068): B<<255.0,432.0>-<244.0,386.0>-<233.0,346.0>>/B<<233.0,346.0>-<252.0,383.0>-<283.5,419.5>> = 11.804859836651074

* hbar (U+0127): B<<254.5,418.5>-<245.0,379.0>-<237.0,346.0>>/B<<237.0,346.0>-<256.0,383.0>-<287.5,419.5>> = 13.554116225585668

* hcircumflex (U+0125): B<<255.0,432.0>-<244.0,386.0>-<233.0,346.0>>/B<<233.0,346.0>-<252.0,383.0>-<283.5,419.5>> = 11.804859836651074

* ordfeminine (U+00AA): B<<226.0,293.5>-<226.0,297.0>-<227.0,301.0>>/B<<227.0,301.0>-<206.0,258.0>-<178.5,237.5>> = 11.993348723586983

* uni021F (U+021F): B<<255.0,432.0>-<244.0,386.0>-<233.0,346.0>>/B<<233.0,346.0>-<252.0,383.0>-<283.5,419.5>> = 11.804859836651074

* uni0265 (U+0265): B<<321.5,68.0>-<333.0,114.0>-<343.0,154.0>>/B<<343.0,154.0>-<324.0,117.0>-<292.5,80.5>> = 13.144867617550734

* uni02B0 (U+02B0): B<<207.0,529.0>-<198.0,496.0>-<189.0,467.0>>/B<<189.0,467.0>-<205.0,494.0>-<232.5,520.5>> = 13.409208558112896

* uni1E23 (U+1E23): B<<255.0,432.0>-<244.0,386.0>-<233.0,346.0>>/B<<233.0,346.0>-<252.0,383.0>-<283.5,419.5>> = 11.804859836651074

* uni1E25 (U+1E25): B<<255.0,432.0>-<244.0,386.0>-<233.0,346.0>>/B<<233.0,346.0>-<252.0,383.0>-<283.5,419.5>> = 11.804859836651074

* 6 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines? outline_semi_vertical
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* summation (U+2211): L<<412.0,564.0>--<247.0,563.0>>

* uni01A9 (U+01A9): L<<408.0,574.0>--<230.0,573.0>>

* uni0335 (U+0335): L<<220.0,243.0>--<80.0,244.0>>

[code: found-semi-vertical]

ℹ️ INFO List all superfamily filepaths superfamily/list
  • ℹ️ INFO

    ofl/agbalumo


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com fontdata_namecheck
ℹ️ INFO Show hinting filesize impact. hinting_impact
  • ℹ️ INFO

    Hinting filesize impact:

ofl/agbalumo/Agbalumo-Regular.ttf
Dehinted Size 1.5Mb
Hinted Size 1.6Mb
Increase 152.2kb
Change 10.1 %
[code: size-impact]
ℹ️ INFO Font contains all required tables? required_tables
  • ℹ️ INFO

    This font contains the following optional tables:

- cvt 

- fpgm

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? googlefonts/description/git_url
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file googlefonts/description/has_article
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
  • ℹ️ INFO

    Latn, Am, Tig, Tir, sgw


    [code: dlng-tag]

  • ℹ️ INFO

    Latn, Am, Tig, Tir, sgw


    [code: slng-tag]

[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 3 11 52 10 160 0
0% 0% 1% 5% 22% 4% 68% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal
Copy link
Collaborator

Outlines / Accents

@yanone

Before/After

I just want to confirm that these changes are intentional!

  • Before
Screenshot 2025-04-17 at 11 42 12
  • After
Screenshot 2025-04-17 at 11 42 04
  • Before
Screenshot 2025-04-17 at 11 42 16
  • After (this one is weird, before the ligature is actually working. But please check if there is no issues about it)
Screenshot 2025-04-17 at 11 42 00

Accents position

Just want to confirm if these positions are ok!

Screenshot 2025-04-17 at 11 46 14 Screenshot 2025-04-17 at 11 47 02 Screenshot 2025-04-17 at 11 49 32

@emmamarichal
Copy link
Collaborator

Fontbakery

  • 🔥 FAIL Ensure the font supports case swapping for all its glyphs.

  • 🔥 FAIL Shapes languages in all GF glyphsets.
    -> It's a commissioned font, should these fails solved?

  • 🔥 FAIL METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
    -> A Warn says that Raphael Alẹ́gbẹ́lẹ́yẹ̀ is not listed, but he is (maybe false positive because of complexe accents?).
    Yikunoamlak Ayalew doesn't have any avatar. (weird that is a fail, I would use a Warn for this kind of issue).

  • ⚠️ WARN Ensure Stylistic Sets have description.
    -> Very easy to add if the fonts are exported again before merging the PR.

  • ⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
    -> It's a commissioned font, no article?

@yanone yanone marked this pull request as draft April 23, 2025 15:21
@yanone
Copy link
Collaborator Author

yanone commented Apr 24, 2025

I double-checked that Raphael Alẹ́gbẹ́lẹ́yẹ̀ is present in the catalog and METADATA.pb by that precise spelling.

The issue comes from Fontbakery that uses a very primitive normalization algorithm to turn accented letters into the ASCII letters used for the folder names - which is what it checks for. In fact that part used to work but in FB issue 3316 it was decided to remove a unicode dependency and instead use this manual translation table:
https://github.com/fonttools/fontbakery/blob/5e5b8f6cbf749e34bbf854f60613e7d19a42ae4e/Lib/fontbakery/checks/vendorspecific/googlefonts/metadata/designer_profiles.py#L29

But the main point is that GF website doesn't use the folder names for identification of designer profiles. Instead it reads all designer profiles into a database and then compares the designer name data from METADATA.pb against the designer names as written in catalog/designers/*/info.pb (at least that's what I was told). These are the ones that need to match, and I confirmed that they do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Font Upgrade II African Mostly west african non-latin and African indigenous scripts II Commissioned Commissioned project to do
Projects
Status: PR GF
Development

Successfully merging this pull request may close these issues.

Update Agbalumo with new Ethiopic (Ge'ez) language support
2 participants