-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Agbalumo: Version 2.000; ttfautohint (v1.8.4.7-5d5b) added #9344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Taken from the upstream repo https://github.com/SorkinType/Agbalumo at commit SorkinType/Agbalumo@4b00209. Resolves #8913
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.13.2 Check results[23] Agbalumo-Regular.ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs. case_mapping
🔥 FAIL METADATA.pb: Designers are listed correctly on the Google Fonts catalog? googlefonts/metadata/designer_profiles
🔥 FAIL Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
|
ofl/agbalumo/Agbalumo-Regular.ttf | |
---|---|
Dehinted Size | 1.5Mb |
Hinted Size | 1.6Mb |
Increase | 152.2kb |
Change | 10.1 % |
ℹ️ INFO Font contains all required tables? required_tables
- ℹ️ INFO
This font contains the following optional tables:
- cvt
- fpgm
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? googlefonts/description/git_url
- ℹ️ INFO
Found a git repo URL: https://github.com/SorkinType/Agbalumo
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file googlefonts/description/has_article
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges]ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
-
ℹ️ INFO
Latn, Am, Tig, Tir, sgw
[code: dlng-tag] -
ℹ️ INFO
Latn, Am, Tig, Tir, sgw
[code: slng-tag]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
- ℹ️ INFO
All of the fonts lack a STAT table.
[code: summary]
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 3 | 11 | 52 | 10 | 160 | 0 |
0% | 0% | 1% | 5% | 22% | 4% | 68% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Fontbakery
|
I double-checked that Raphael Alẹ́gbẹ́lẹ́yẹ̀ is present in the catalog and The issue comes from Fontbakery that uses a very primitive normalization algorithm to turn accented letters into the ASCII letters used for the folder names - which is what it checks for. In fact that part used to work but in FB issue 3316 it was decided to remove a unicode dependency and instead use this manual translation table: But the main point is that GF website doesn't use the folder names for identification of designer profiles. Instead it reads all designer profiles into a database and then compares the designer name data from |
Taken from the upstream repo https://github.com/SorkinType/Agbalumo at commit SorkinType/Agbalumo@4b00209.
Resolves #8913
PR Checklist:
tags
are added for NEW FONTSsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.