-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Menbere: Version 1.000 added #9345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FontBakery reportfontbakery version: 0.13.2 Check results[17] Menbere[wght].ttf🔥 FAIL METADATA.pb: Designers are listed correctly on the Google Fonts catalog? googlefonts/metadata/designer_profiles
🔥 FAIL Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
|
| ofl/menbere/Menbere[wght].ttf | |
|---|---|
| Dehinted Size | 2.5Mb |
| Hinted Size | 2.5Mb |
| Increase | 24 bytes |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? required_tables
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
- vhea
- vmtx
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges]ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
-
ℹ️ INFO
Ethi
[code: dlng-tag] -
ℹ️ INFO
Ethi, Latn
[code: slng-tag]
ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
- ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000']
[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
- ℹ️ INFO
None of the fonts lack a STAT table.
And these are the most common STAT axis orderings:
('wght', 1)
[code: summary]
Summary
| 💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
|---|---|---|---|---|---|---|---|
| 0 | 0 | 2 | 8 | 40 | 8 | 178 | 0 |
| 0% | 0% | 1% | 3% | 17% | 3% | 75% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
|
@yanone some of these fails could be solved: Fontbakery report:
|
27b6249 to
9324ebb
Compare
FontSpector reportfontspector version: 1.0.2 Checks with FATAL resultsThese must be addressed first. [2] ofl/menbere/Menbere[wght].ttf💥 ERROR Version number has increased since previous release on Google Fonts? (googlefonts/version_bump)
💥 ERROR Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts. (googlefonts/vertical_metrics_regressions)
All other checks[4] ofl/menbere🔥 FAIL Check for presence of an ARTICLE.en_us.html file (googlefonts/description/has_article)
🔥 FAIL Check font has a license. (googlefonts/family/has_license)
|
| Mandatory orthography codepoints: The following mark characters are missing from the font: ̩ | * yo_Latn (Yoruba) |
⚠️ WARN Warning language shaping:
| Auxiliary orthography codepoints: Shaper didn't attach acutecomb to Uogonek when shaping the text 'Ų́' Shaper didn't attach tildecomb to Uogonek when shaping the text 'Ų̃' | * lt_Latn (Lithuanian) |
| Auxiliary orthography codepoints: The following auxiliary characters are missing from the font: Ŧ The following auxiliary characters are missing from the font: ŧ | * nb_Latn (Norwegian Bokmål) |
| Auxiliary orthography codepoints: The following auxiliary characters are missing from the font: e̩ The following auxiliary characters are missing from the font: E̩ The following auxiliary characters are missing from the font: é̩ The following auxiliary characters are missing from the font: É̩ The following auxiliary characters are missing from the font: è̩ The following auxiliary characters are missing from the font: È̩ The following auxiliary characters are missing from the font: ê̩ The following auxiliary characters are missing from the font: Ê̩ The following auxiliary characters are missing from the font: ě̩ The following auxiliary characters are missing from the font: Ě̩ The following auxiliary characters are missing from the font: o̩ The following auxiliary characters are missing from the font: O̩ The following auxiliary characters are missing from the font: ó̩ The following auxiliary characters are missing from the font: Ó̩ The following auxiliary characters are missing from the font: ò̩ The following auxiliary characters are missing from the font: Ò̩ The following auxiliary characters are missing from the font: ô̩ The following auxiliary characters are missing from the font: Ô̩ The following auxiliary characters are missing from the font: ǒ̩ The following auxiliary characters are missing from the font: Ǒ̩ The following auxiliary characters are missing from the font: s̩ The following auxiliary characters are missing from the font: S̩ | * yo_Latn (Yoruba) |
| Auxiliary orthography codepoints: The following auxiliary characters are missing from the font: ſ | * de_Latn (German) * fr_Latn (French) |
| Auxiliary orthography codepoints: The following auxiliary characters are missing from the font: ɵ The following auxiliary characters are missing from the font: Ɵ | * ig_Latn (Igbo) |
| Auxiliary orthography codepoints: The following auxiliary characters are missing from the font: ʻ | * en_Latn (English) |
| Auxiliary orthography codepoints: The following auxiliary characters are missing from the font: Ǥ The following auxiliary characters are missing from the font: Ŧ The following auxiliary characters are missing from the font: Ʒ The following auxiliary characters are missing from the font: Ǯ The following auxiliary characters are missing from the font: ǥ The following auxiliary characters are missing from the font: ŧ The following auxiliary characters are missing from the font: ʒ The following auxiliary characters are missing from the font: ǯ | * fi_Latn (Finnish) |
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
-
⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
infered from the typical ammounts of contours observed in a
large collection of reference font families. The divergences
listed below may simply indicate a significantly different
design on some of your glyphs. On the other hand, some of these
may flag actual bugs in the font such as glyphs mapped to an
incorrect codepoint. Please consider reviewing the design and
codepoint assignment of these to make sure they are correct.The following glyphs do not have the recommended number of contours:
- uni01C2 (U+01C2): found 3, expected one of: {1} [code: contour-count]
⚠️ WARN Ensure files are not too large. (file_size)
⚠️ WARN Font file is 2.65 MB; ideally it should be less than 1.05 MB [code: large-font]
⚠️ WARN Detect any interpolation issues in the font. (interpolation_issues)
⚠️ WARN Glyph uni0200 has interpolation issues:
- Contour order mismatch: [0, 1, 2, 3] in default vs [0, 1, 3, 2] in wght=700 [code: glyph]
⚠️ WARN Glyph uni0204 has interpolation issues:
- Contour order mismatch: [0, 1, 2] in default vs [0, 2, 1] in wght=700 [code: glyph]
⚠️ WARN Glyph uni0208 has interpolation issues:
- Contour order mismatch: [0, 1, 2] in default vs [0, 2, 1] in wght=700 [code: glyph]
⚠️ WARN Glyph uni020C has interpolation issues:
- Contour order mismatch: [0, 1, 2, 3] in default vs [0, 1, 3, 2] in wght=700 [code: glyph]
⚠️ WARN Glyph uni0214 has interpolation issues:
- Contour order mismatch: [0, 1, 2] in default vs [0, 2, 1] in wght=700 [code: glyph]
⚠️ WARN Glyph uni0201 has interpolation issues:
- Contour order mismatch: [0, 1, 2, 3] in default vs [0, 1, 3, 2] in wght=700 [code: glyph]
⚠️ WARN Glyph uni0205 has interpolation issues:
- Contour order mismatch: [0, 1, 2, 3] in default vs [0, 1, 3, 2] in wght=700 [code: glyph]
⚠️ WARN Glyph uni0209 has interpolation issues:
- Contour order mismatch: [0, 1, 2] in default vs [0, 2, 1] in wght=700 [code: glyph]
⚠️ WARN Glyph uni020D has interpolation issues:
- Contour order mismatch: [0, 1, 2, 3] in default vs [0, 1, 3, 2] in wght=700 [code: glyph]
⚠️ WARN Glyph uni0215 has interpolation issues:
- Contour order mismatch: [0, 1, 2] in default vs [0, 2, 1] in wght=700 [code: glyph]
⚠️ WARN Glyph uni1345 has interpolation issues:
- Wrong start point: contour 2 should start at 10 in wght=100 [code: glyph]
⚠️ WARN Glyph colon has interpolation issues:
- Contour order mismatch: [0, 1] in default vs [1, 0] in wght=100 [code: glyph]
⚠️ WARN Glyph exclamdown has interpolation issues:
- Wrong start point: contour 0 should start at 2 in wght=100 [code: glyph]
⚠️ WARN Glyph exclamdown has interpolation issues:
- Wrong start point: contour 0 should start at 2 in wght=700 [code: glyph]
⚠️ WARN Glyph guillemotleft has interpolation issues:
- Contour order mismatch: [0, 1] in default vs [1, 0] in wght=700 [code: glyph]
⚠️ WARN Glyph quotedbl has interpolation issues:
- Contour order mismatch: [0, 1] in default vs [1, 0] in wght=100 [code: glyph]
⚠️ WARN Glyph uni030F has interpolation issues:
- Contour order mismatch: [0, 1] in default vs [1, 0] in wght=700 [code: glyph]
⚠️ WARN Glyph uni030F.case has interpolation issues:
- Contour order mismatch: [0, 1] in default vs [1, 0] in wght=700 [code: glyph]
⚠️ WARN Glyph hungarumlaut has interpolation issues:
- Contour order mismatch: [0, 1] in default vs [1, 0] in wght=100 [code: glyph]
⚠️ WARN Glyph hungarumlaut has interpolation issues:
- Contour order mismatch: [0, 1] in default vs [1, 0] in wght=700 [code: glyph]
⚠️ WARN Check math signs have the same width. (math_signs_width)
⚠️ WARN The most common width is 582 among a set of 10 math glyphs.
The following math glyphs have a different width, though:
width=578: equal
width=583: logicalnot
width=553: plusminus, approxequal
width=433: minus [code: width-outliers]
⚠️ WARN Ensure indic fonts have the Indian Rupee Sign glyph. (rupee)
⚠️ WARN Font is missing the Indian Rupee Sign glyph. Please add a glyph for Indian Rupee Sign (₹) at codepoint U+20B9. [code: missing-rupee]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
- space_sm5
- overscorecomb [code: unreachable-glyphs]
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
⚠️ WARN The following separator glyphs are missing:
- U+2028
- U+2029 [code: missing-separator-glyphs]
⚠️ WARN Check font follows the Google Fonts vertical metric schema (googlefonts/vertical_metrics)
⚠️ WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.567x (1567) [code: bad-hhea-range]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
- ℹ️ INFO OS/2 xAvgCharWidth is 730 but it should be 729 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622 [code: xAvgCharWidth-close]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| Menbere[wght].ttf | |
|---|---|
| Dehinted Size | 2647824 |
| Hinted Size | 2647848 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp
vhea
vmtx [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType® |
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
-
ℹ️ INFO "Ethi" [code: dlng-tag]
-
ℹ️ INFO "Ethi, Latn" [code: slng-tag]
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.000 [code: version-not-detected]
Summary
| ✅ PASS | 💥 ERROR | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | |
|---|---|---|---|---|---|
| 113 | 29 | 2 | 3 | 45 | 8 |
| 63% | 16% | 1% | 2% | 25% | 4% |
Taken from the upstream repo https://github.com/SorkinType/Menbere at commit SorkinType/Menbere@ab34feb.
|
Updated |
9324ebb to
a2d0206
Compare
FontSpector reportfontspector version: 1.0.2 Check results[4] ofl/menbere🔥 FAIL Check font has a license. (googlefonts/family/has_license)
|
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ŧ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: ſ | * fr_Latn (French) |
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: ŧ | |
| Auxiliary orthography codepoints: | * ig_Latn (Igbo) |
| The following auxiliary characters are missing from the font: ɵ | |
| The following auxiliary characters are missing from the font: Ɵ |
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
⚠️ WARN The following separator glyphs are missing:
- U+2028
- U+2029 [code: missing-separator-glyphs]
⚠️ WARN Check font follows the Google Fonts vertical metric schema (googlefonts/vertical_metrics)
⚠️ WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.567x (1567) [code: bad-hhea-range]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| Menbere[wght].ttf | |
|---|---|
| Dehinted Size | 2717300 |
| Hinted Size | 2717324 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp
vhea
vmtx [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
-
ℹ️ INFO "Ethi" [code: dlng-tag]
-
ℹ️ INFO "Ethi, Latn" [code: slng-tag]
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.000 [code: version-not-detected]
Summary
| ✅ PASS | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | |
|---|---|---|---|---|
| 116 | 8 | 1 | 47 | 8 |
| 65% | 4% | 1% | 26% | 4% |
FontSpector reportfontspector version: 1.0.2 Check results[4] ofl/menbere🔥 FAIL Check font has a license. (googlefonts/family/has_license)
|
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * ig_Latn (Igbo) |
| The following auxiliary characters are missing from the font: ɵ | |
| The following auxiliary characters are missing from the font: Ɵ | |
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ŧ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: ŧ | |
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: ſ | * fr_Latn (French) |
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
⚠️ WARN The following separator glyphs are missing:
- U+2028
- U+2029 [code: missing-separator-glyphs]
⚠️ WARN Check font follows the Google Fonts vertical metric schema (googlefonts/vertical_metrics)
⚠️ WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.567x (1567) [code: bad-hhea-range]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| Menbere[wght].ttf | |
|---|---|
| Dehinted Size | 2717300 |
| Hinted Size | 2717324 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp
vhea
vmtx [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
-
ℹ️ INFO "Ethi" [code: dlng-tag]
-
ℹ️ INFO "Ethi, Latn" [code: slng-tag]
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.000 [code: version-not-detected]
Summary
| 🔥 FAIL | ✅ PASS | ⏩ SKIP | ℹ️ INFO | |
|---|---|---|---|---|
| 1 | 116 | 47 | 8 | 8 |
| 1% | 65% | 26% | 4% | 4% |






PR Checklist:
PR
QA
Specifics
primary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.Release
minisite_urldefinition in the METADATA.pb file for commissioned projectstagsare added for NEW FONTS