Skip to content

Conversation

@yanone
Copy link
Contributor

@yanone yanone commented Apr 15, 2025

PR Checklist:

PR

  • The PR is in the Traffic Jam Board (Project > Traffic Jam Board)
  • It has the correct labels (upgrade, new font, specific language)
  • The PR is linked to the corresponding issue

QA

  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • The article has no typos, images are properly linked and correctly sized
  • OFL.txt contains the correct license URL (https://openfontlicense.org)

Specifics

  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.

Release

  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • minisite_url definition in the METADATA.pb file for commissioned projects
  • tags are added for NEW FONTS

@yanone yanone added I New Font II African Mostly west african non-latin and African indigenous scripts II Commissioned Commissioned project to do labels Apr 15, 2025
@github-actions
Copy link
Contributor

FontBakery report

fontbakery version: 0.13.2

Check results

[17] Menbere[wght].ttf
🔥 FAIL METADATA.pb: Designers are listed correctly on the Google Fonts catalog? googlefonts/metadata/designer_profiles
  • 🔥 FAIL

    Designer Aleme Tadesse still does not have an avatar image. Please provide one.


    [code: missing-avatar]
🔥 FAIL Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
  • 🔥 FAIL

    GF_Phonetics_SinoExt glyphset:

FAIL messages Languages
Mandatory orthography codepoints:
The following mark characters are missing from the font: ̩ yo_Latn (Yoruba)
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: ſ de_Latn (German) and fr_Latn (French)
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: ʻ en_Latn (English)
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: Ǥ
The following auxiliary characters are missing from the font: Ŧ
The following auxiliary characters are missing from the font: Ʒ
The following auxiliary characters are missing from the font: Ǯ
The following auxiliary characters are missing from the font: ǥ
The following auxiliary characters are missing from the font: ŧ
The following auxiliary characters are missing from the font: ʒ
The following auxiliary characters are missing from the font: ǯ fi_Latn (Finnish)
Auxiliary orthography codepoints:
Shaper didn't attach acutecomb to Uogonek when shaping the text 'Ų́'
Shaper didn't attach tildecomb to Uogonek when shaping the text 'Ų̃' lt_Latn (Lithuanian)
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: Ŧ
The following auxiliary characters are missing from the font: ŧ nb_Latn (Norwegian Bokmål)
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: ɵ
The following auxiliary characters are missing from the font: Ɵ ig_Latn (Igbo)
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: e̩
The following auxiliary characters are missing from the font: E̩
The following auxiliary characters are missing from the font: é̩
The following auxiliary characters are missing from the font: É̩
The following auxiliary characters are missing from the font: è̩
The following auxiliary characters are missing from the font: È̩
The following auxiliary characters are missing from the font: ê̩
The following auxiliary characters are missing from the font: Ê̩
The following auxiliary characters are missing from the font: ě̩
The following auxiliary characters are missing from the font: Ě̩
The following auxiliary characters are missing from the font: o̩
The following auxiliary characters are missing from the font: O̩
The following auxiliary characters are missing from the font: ó̩
The following auxiliary characters are missing from the font: Ó̩
The following auxiliary characters are missing from the font: ò̩
The following auxiliary characters are missing from the font: Ò̩
The following auxiliary characters are missing from the font: ô̩
The following auxiliary characters are missing from the font: Ô̩
The following auxiliary characters are missing from the font: ǒ̩
The following auxiliary characters are missing from the font: Ǒ̩
The following auxiliary characters are missing from the font: s̩
The following auxiliary characters are missing from the font: S̩ yo_Latn (Yoruba)
[code: warning-language-shaping]
⚠️ WARN Ensure files are not too large. file_size
  • ⚠️ WARN

    Font file is 2.5Mb; ideally it should be less than 1.0Mb


    [code: large-font]
⚠️ WARN Detect any interpolation issues in the font. interpolation_issues
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour order differs in glyph 'hungarumlaut': [0, 1] in wght=400, [1, 0] in wght=100.

- Contour order differs in glyph 'uni030F.case': [0, 1] in wght=100, [1, 0] in wght=700.

- Contour 0 start point differs in glyph 'exclamdown' between location wght=400 and location wght=100

- Contour 0 in glyph 'exclamdown': becomes underweight between wght=400 and wght=100.

- Contour order differs in glyph 'guillemotleft': [0, 1] in wght=100, [1, 0] in wght=700.

- Contour order differs in glyph 'quotedbl': [0, 1] in wght=400, [1, 0] in wght=100.

- Contour order differs in glyph 'quotedbl': [0, 1] in wght=100, [1, 0] in wght=700.

- Contour 0 start point differs in glyph 'multiply' between location wght=100 and location wght=700

- Contour 0 in glyph 'uni1210': becomes underweight between wght=100 and wght=700.

- Contour order differs in glyph 'colon': [0, 1] in wght=400, [1, 0] in wght=100.

- 6 more.

Use -F or --full-lists to disable shortening of long lists.

[code: interpolation-issues]
⚠️ WARN Check math signs have the same width. math_signs_width
  • ⚠️ WARN

    The most common width is 582 among a set of 5 math glyphs.
    The following math glyphs have a different width, though:

Width = 578: equal

Width = 583: logicalnot

Width = 553: plusminus, approxequal

Width = 433: minus

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs unreachable_glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- overscorecomb

- space_sm5

[code: unreachable-glyphs]

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets. googlefonts/article/images
  • ⚠️ WARN

    Article page lacks visual assets.


    [code: missing-visual-asset]
⚠️ WARN METADATA.pb: Check for primary_script googlefonts/metadata/primary_script
  • ⚠️ WARN

    METADATA.pb: primary_script field should be 'Ethi' but is missing.


    [code: missing-primary-script]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, tifinagh, math, cherokee
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, old-permic, syriac, tai-le, canadian-aboriginal, malayalam, todhri, coptic, duployan, math, hebrew
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+030F COMBINING DOUBLE GRAVE ACCENT: not included in any glyphset definition 85 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: ethiopic, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Check font follows the Google Fonts vertical metric schema googlefonts/vertical_metrics
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.567x (1567)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths superfamily/list
  • ℹ️ INFO

    ofl/menbere


    [code: family-path]
ℹ️ INFO Show hinting filesize impact. hinting_impact
  • ℹ️ INFO

    Hinting filesize impact:

ofl/menbere/Menbere[wght].ttf
Dehinted Size 2.5Mb
Hinted Size 2.5Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables? required_tables
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
  • ℹ️ INFO

    Ethi


    [code: dlng-tag]

  • ℹ️ INFO

    Ethi, Latn


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 8 40 8 178 0
0% 0% 1% 3% 17% 3% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal
Copy link
Collaborator

emmamarichal commented Apr 16, 2025

@yanone some of these fails could be solved:

Fontbakery report:

  • 🔥 FAIL METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
    -> Bios for upcoming Menbere and Agbalumo #9140
  • 🔥 FAIL Shapes languages in all GF glyphsets.
    -> Would be nice to solve at least the first one: yo_Latn (Yoruba) by adding anchors to ̩
  • ⚠️ WARN Detect any interpolation issues in the font.
    -> colon/guillemotleft/hungarumlaut/quotedbl/uni030F/uni030F.case/exclamdown/multiply/uni1345/exclamdown/uni1210/uni1345
Screenshot 2025-04-16 at 14 05 50
  • ⚠️ WARN METADATA.pb: Check for primary_script
    -> we need to add 'Ethi'

  • ⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
    -> It's a commissioned font, so we need images for the article

  • ⚠️ WARN Check font follows the Google Fonts vertical metric schema
    -> Is there a specific reason why the typeface doesn't follow the specs for the v-metrics?

  • ⚠️ WARN Check font contains no unreachable glyphs
    -> This WARN can be avoid by just un-export the two concerned glyphs

@emmamarichal
Copy link
Collaborator

emmamarichal commented Apr 16, 2025

Some other outlines issues:

-Spacing issue?

Screen.Recording.2025-04-16.at.14.25.58.mov
Screenshot 2025-04-16 at 14 25 23 Screenshot 2025-04-16 at 14 25 27 Screenshot 2025-04-16 at 14 26 25 Screenshot 2025-04-16 at 14 26 34 Screenshot 2025-04-16 at 14 27 25

For these ones, it's not a mistake, just maybe something in the design that isn't logical, in terms of alignment.

Screen.Recording.2025-04-16.at.14.29.06.mov
Screen.Recording.2025-04-16.at.14.29.23.mov

@yanone yanone marked this pull request as draft April 23, 2025 15:21
@emmamarichal emmamarichal force-pushed the gftools_packager_ofl_menbere branch from 27b6249 to 9324ebb Compare May 23, 2025 13:57
@github-actions
Copy link
Contributor

FontSpector report

fontspector version: 1.0.2

Checks with FATAL results

These must be addressed first.

[2] ofl/menbere/Menbere[wght].ttf
💥 ERROR Version number has increased since previous release on Google Fonts? (googlefonts/version_bump)
  • 💥 ERROR Error: Failed to find fileRefs in manifest: Object {"error": String("Unable to find family: Menbere")}
💥 ERROR Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts. (googlefonts/vertical_metrics_regressions)
  • 💥 ERROR Error: Could not get remote style: Failed to find fileRefs in manifest: Object {"error": String("Unable to find family: Menbere")}

All other checks

[4] ofl/menbere
🔥 FAIL Check for presence of an ARTICLE.en_us.html file (googlefonts/description/has_article)
  • 🔥 FAIL This font doesn't have an ARTICLE.en_us.html file. [code: missing-article]
🔥 FAIL Check font has a license. (googlefonts/family/has_license)
  • 🔥 FAIL No license file was found. Please add an OFL.txt or a LICENSE.txt file. [code: no-license]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
  • ⚠️ WARN ofl/menbere/Menbere[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, math, tifinagh, coptic
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: canadian-aboriginal, duployan, todhri, syriac, old-permic, coptic, hebrew, math, malayalam, tai-le, tifinagh
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
    ... and 82 others

Or you can add the above codepoints to one of the subsets supported by the font: ethiopic, latin-ext, latin [code: unreachable-subsetting]

ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
  • ℹ️ INFO None of the fonts lack a STAT table.

    And these are the most common STAT axis orderings:
    wght: 1 [code: summary]

[15] ofl/menbere/Menbere[wght].ttf
🔥 FAIL Shapes languages in all GF glyphsets. (googlefonts/glyphsets/shape_languages)
  • 🔥 FAIL Failed language shaping:
Mandatory orthography codepoints: The following mark characters are missing from the font: ̩* yo_Latn (Yoruba)
[code: failed-language-shaping]
  • ⚠️ WARN Warning language shaping:
Auxiliary orthography codepoints: Shaper didn't attach acutecomb to Uogonek when shaping the text 'Ų́' Shaper didn't attach tildecomb to Uogonek when shaping the text 'Ų̃'* lt_Latn (Lithuanian)
Auxiliary orthography codepoints: The following auxiliary characters are missing from the font: Ŧ The following auxiliary characters are missing from the font: ŧ* nb_Latn (Norwegian Bokmål)
Auxiliary orthography codepoints: The following auxiliary characters are missing from the font: e̩ The following auxiliary characters are missing from the font: E̩ The following auxiliary characters are missing from the font: é̩ The following auxiliary characters are missing from the font: É̩ The following auxiliary characters are missing from the font: è̩ The following auxiliary characters are missing from the font: È̩ The following auxiliary characters are missing from the font: ê̩ The following auxiliary characters are missing from the font: Ê̩ The following auxiliary characters are missing from the font: ě̩ The following auxiliary characters are missing from the font: Ě̩ The following auxiliary characters are missing from the font: o̩ The following auxiliary characters are missing from the font: O̩ The following auxiliary characters are missing from the font: ó̩ The following auxiliary characters are missing from the font: Ó̩ The following auxiliary characters are missing from the font: ò̩ The following auxiliary characters are missing from the font: Ò̩ The following auxiliary characters are missing from the font: ô̩ The following auxiliary characters are missing from the font: Ô̩ The following auxiliary characters are missing from the font: ǒ̩ The following auxiliary characters are missing from the font: Ǒ̩ The following auxiliary characters are missing from the font: s̩ The following auxiliary characters are missing from the font: S̩* yo_Latn (Yoruba)
Auxiliary orthography codepoints: The following auxiliary characters are missing from the font: ſ* de_Latn (German) * fr_Latn (French)
Auxiliary orthography codepoints: The following auxiliary characters are missing from the font: ɵ The following auxiliary characters are missing from the font: Ɵ* ig_Latn (Igbo)
Auxiliary orthography codepoints: The following auxiliary characters are missing from the font: ʻ* en_Latn (English)
Auxiliary orthography codepoints: The following auxiliary characters are missing from the font: Ǥ The following auxiliary characters are missing from the font: Ŧ The following auxiliary characters are missing from the font: Ʒ The following auxiliary characters are missing from the font: Ǯ The following auxiliary characters are missing from the font: ǥ The following auxiliary characters are missing from the font: ŧ The following auxiliary characters are missing from the font: ʒ The following auxiliary characters are missing from the font: ǯ* fi_Latn (Finnish)
[code: warning-language-shaping]
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
    infered from the typical ammounts of contours observed in a
    large collection of reference font families. The divergences
    listed below may simply indicate a significantly different
    design on some of your glyphs. On the other hand, some of these
    may flag actual bugs in the font such as glyphs mapped to an
    incorrect codepoint. Please consider reviewing the design and
    codepoint assignment of these to make sure they are correct.

    The following glyphs do not have the recommended number of contours:

  • uni01C2 (U+01C2): found 3, expected one of: {1} [code: contour-count]
⚠️ WARN Ensure files are not too large. (file_size)
  • ⚠️ WARN Font file is 2.65 MB; ideally it should be less than 1.05 MB [code: large-font]
⚠️ WARN Detect any interpolation issues in the font. (interpolation_issues)
  • ⚠️ WARN Glyph uni0200 has interpolation issues:
  • Contour order mismatch: [0, 1, 2, 3] in default vs [0, 1, 3, 2] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph uni0204 has interpolation issues:
  • Contour order mismatch: [0, 1, 2] in default vs [0, 2, 1] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph uni0208 has interpolation issues:
  • Contour order mismatch: [0, 1, 2] in default vs [0, 2, 1] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph uni020C has interpolation issues:
  • Contour order mismatch: [0, 1, 2, 3] in default vs [0, 1, 3, 2] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph uni0214 has interpolation issues:
  • Contour order mismatch: [0, 1, 2] in default vs [0, 2, 1] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph uni0201 has interpolation issues:
  • Contour order mismatch: [0, 1, 2, 3] in default vs [0, 1, 3, 2] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph uni0205 has interpolation issues:
  • Contour order mismatch: [0, 1, 2, 3] in default vs [0, 1, 3, 2] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph uni0209 has interpolation issues:
  • Contour order mismatch: [0, 1, 2] in default vs [0, 2, 1] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph uni020D has interpolation issues:
  • Contour order mismatch: [0, 1, 2, 3] in default vs [0, 1, 3, 2] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph uni0215 has interpolation issues:
  • Contour order mismatch: [0, 1, 2] in default vs [0, 2, 1] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph uni1345 has interpolation issues:
  • Wrong start point: contour 2 should start at 10 in wght=100 [code: glyph]
  • ⚠️ WARN Glyph colon has interpolation issues:
  • Contour order mismatch: [0, 1] in default vs [1, 0] in wght=100 [code: glyph]
  • ⚠️ WARN Glyph exclamdown has interpolation issues:
  • Wrong start point: contour 0 should start at 2 in wght=100 [code: glyph]
  • ⚠️ WARN Glyph exclamdown has interpolation issues:
  • Wrong start point: contour 0 should start at 2 in wght=700 [code: glyph]
  • ⚠️ WARN Glyph guillemotleft has interpolation issues:
  • Contour order mismatch: [0, 1] in default vs [1, 0] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph quotedbl has interpolation issues:
  • Contour order mismatch: [0, 1] in default vs [1, 0] in wght=100 [code: glyph]
  • ⚠️ WARN Glyph uni030F has interpolation issues:
  • Contour order mismatch: [0, 1] in default vs [1, 0] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph uni030F.case has interpolation issues:
  • Contour order mismatch: [0, 1] in default vs [1, 0] in wght=700 [code: glyph]
  • ⚠️ WARN Glyph hungarumlaut has interpolation issues:
  • Contour order mismatch: [0, 1] in default vs [1, 0] in wght=100 [code: glyph]
  • ⚠️ WARN Glyph hungarumlaut has interpolation issues:
  • Contour order mismatch: [0, 1] in default vs [1, 0] in wght=700 [code: glyph]
⚠️ WARN Check math signs have the same width. (math_signs_width)
  • ⚠️ WARN The most common width is 582 among a set of 10 math glyphs.
    The following math glyphs have a different width, though:
    width=578: equal
    width=583: logicalnot
    width=553: plusminus, approxequal
    width=433: minus [code: width-outliers]
⚠️ WARN Ensure indic fonts have the Indian Rupee Sign glyph. (rupee)
  • ⚠️ WARN Font is missing the Indian Rupee Sign glyph. Please add a glyph for Indian Rupee Sign (₹) at codepoint U+20B9. [code: missing-rupee]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
  • ⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
  • space_sm5
  • overscorecomb [code: unreachable-glyphs]
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
  • ⚠️ WARN The following separator glyphs are missing:
  • U+2028
  • U+2029 [code: missing-separator-glyphs]
⚠️ WARN Check font follows the Google Fonts vertical metric schema (googlefonts/vertical_metrics)
  • ⚠️ WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.567x (1567) [code: bad-hhea-range]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
  • ℹ️ INFO Hinting filesize impact:
Menbere[wght].ttf
Dehinted Size 2647824
Hinted Size 2647848
Increase 24
Change 0.0 %
ℹ️ INFO Font contains all required tables? (required_tables)
  • ℹ️ INFO This font contains the following optional tables:

    loca
    prep
    GPOS
    GSUB
    gasp
    vhea
    vmtx [code: optional-tables]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
  • ℹ️ INFO These are the ppm ranges declared on the gasp table:
PPM <= 65535- Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
  • ℹ️ INFO "Ethi" [code: dlng-tag]

  • ℹ️ INFO "Ethi, Latn" [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
  • ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.000 [code: version-not-detected]

Summary

✅ PASS ⚠️ WARN 💥 ERROR 🔥 FAIL ⏩ SKIP ℹ️ INFO
113 29 2 3 45 8
63% 16% 1% 2% 25% 4%

@emmamarichal
Copy link
Collaborator

Updated

@emmamarichal emmamarichal force-pushed the gftools_packager_ofl_menbere branch from 9324ebb to a2d0206 Compare June 5, 2025 08:52
@emmamarichal emmamarichal marked this pull request as ready for review June 5, 2025 08:56
@emmamarichal emmamarichal linked an issue Jun 5, 2025 that may be closed by this pull request
9 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

FontSpector report

fontspector version: 1.0.2

Check results

[4] ofl/menbere
🔥 FAIL Check font has a license. (googlefonts/family/has_license)
  • 🔥 FAIL No license file was found. Please add an OFL.txt or a LICENSE.txt file. [code: no-license]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
  • ⚠️ WARN ofl/menbere/Menbere[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, cherokee, coptic, math
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: canadian-aboriginal, hebrew, todhri, duployan, math, tai-le, old-permic, coptic, malayalam, syriac, tifinagh
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
    ... and 66 others

Or you can add the above codepoints to one of the subsets supported by the font: ethiopic, latin-ext, latin, vietnamese [code: unreachable-subsetting]

ℹ️ INFO Check for presence of an ARTICLE.en_us.html file (googlefonts/description/has_article)
  • ℹ️ INFO This font doesn't have an ARTICLE.en_us.html file. [code: missing-article]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
  • ℹ️ INFO None of the fonts lack a STAT table.

    And these are the most common STAT axis orderings:
    wght: 1 [code: summary]

[12] ofl/menbere/Menbere[wght].ttf
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
    infered from the typical ammounts of contours observed in a
    large collection of reference font families. The divergences
    listed below may simply indicate a significantly different
    design on some of your glyphs. On the other hand, some of these
    may flag actual bugs in the font such as glyphs mapped to an
    incorrect codepoint. Please consider reviewing the design and
    codepoint assignment of these to make sure they are correct.

    The following glyphs do not have the recommended number of contours:

  • uni01C2 (U+01C2): found 3, expected one of: {1} [code: contour-count]
⚠️ WARN Ensure files are not too large. (file_size)
  • ⚠️ WARN Font file is 2.72 MB; ideally it should be less than 1.05 MB [code: large-font]
⚠️ WARN Check math signs have the same width. (math_signs_width)
  • ⚠️ WARN The most common width is 582 among a set of 11 math glyphs.
    The following math glyphs have a different width, though:
    width=600: notequal
    width=433: minus
    width=578: equal
    width=583: logicalnot
    width=553: plusminus, approxequal [code: width-outliers]
⚠️ WARN Ensure indic fonts have the Indian Rupee Sign glyph. (rupee)
  • ⚠️ WARN Font is missing the Indian Rupee Sign glyph. Please add a glyph for Indian Rupee Sign (₹) at codepoint U+20B9. [code: missing-rupee]
⚠️ WARN Shapes languages in all GF glyphsets. (googlefonts/glyphsets/shape_languages)
  • ⚠️ WARN Warning language shaping:
Message Languages
Auxiliary orthography codepoints: * fi_Latn (Finnish)
The following auxiliary characters are missing from the font: Ǥ
The following auxiliary characters are missing from the font: Ŧ
The following auxiliary characters are missing from the font: Ʒ
The following auxiliary characters are missing from the font: Ǯ
The following auxiliary characters are missing from the font: ǥ
The following auxiliary characters are missing from the font: ŧ
The following auxiliary characters are missing from the font: ʒ
The following auxiliary characters are missing from the font: ǯ
Auxiliary orthography codepoints: * de_Latn (German)
The following auxiliary characters are missing from the font: ſ * fr_Latn (French)
Auxiliary orthography codepoints: * nb_Latn (Norwegian Bokmål)
The following auxiliary characters are missing from the font: Ŧ
The following auxiliary characters are missing from the font: ŧ
Auxiliary orthography codepoints: * ig_Latn (Igbo)
The following auxiliary characters are missing from the font: ɵ
The following auxiliary characters are missing from the font: Ɵ
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
  • ⚠️ WARN The following separator glyphs are missing:
  • U+2028
  • U+2029 [code: missing-separator-glyphs]
⚠️ WARN Check font follows the Google Fonts vertical metric schema (googlefonts/vertical_metrics)
  • ⚠️ WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.567x (1567) [code: bad-hhea-range]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
  • ℹ️ INFO Hinting filesize impact:
Menbere[wght].ttf
Dehinted Size 2717300
Hinted Size 2717324
Increase 24
Change 0.0 %
ℹ️ INFO Font contains all required tables? (required_tables)
  • ℹ️ INFO This font contains the following optional tables:

    loca
    prep
    GPOS
    GSUB
    gasp
    vhea
    vmtx [code: optional-tables]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
  • ℹ️ INFO These are the ppm ranges declared on the gasp table:

| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |

- Use smoothing along multiple axes with ClearType®
[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
  • ℹ️ INFO "Ethi" [code: dlng-tag]

  • ℹ️ INFO "Ethi, Latn" [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
  • ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.000 [code: version-not-detected]

Summary

✅ PASS ⚠️ WARN 🔥 FAIL ⏩ SKIP ℹ️ INFO
116 8 1 47 8
65% 4% 1% 26% 4%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

FontSpector report

fontspector version: 1.0.2

Check results

[4] ofl/menbere
🔥 FAIL Check font has a license. (googlefonts/family/has_license)
  • 🔥 FAIL No license file was found. Please add an OFL.txt or a LICENSE.txt file. [code: no-license]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
  • ⚠️ WARN ofl/menbere/Menbere[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, coptic, tifinagh, math
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: syriac, canadian-aboriginal, duployan, hebrew, malayalam, coptic, tai-le, math, tifinagh, old-permic, todhri
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
    ... and 66 others

Or you can add the above codepoints to one of the subsets supported by the font: ethiopic, latin-ext, latin, vietnamese [code: unreachable-subsetting]

ℹ️ INFO Check for presence of an ARTICLE.en_us.html file (googlefonts/description/has_article)
  • ℹ️ INFO This font doesn't have an ARTICLE.en_us.html file. [code: missing-article]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
  • ℹ️ INFO None of the fonts lack a STAT table.

    And these are the most common STAT axis orderings:
    wght: 1 [code: summary]

[12] ofl/menbere/Menbere[wght].ttf
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
    infered from the typical ammounts of contours observed in a
    large collection of reference font families. The divergences
    listed below may simply indicate a significantly different
    design on some of your glyphs. On the other hand, some of these
    may flag actual bugs in the font such as glyphs mapped to an
    incorrect codepoint. Please consider reviewing the design and
    codepoint assignment of these to make sure they are correct.

    The following glyphs do not have the recommended number of contours:

  • uni01C2 (U+01C2): found 3, expected one of: {1} [code: contour-count]
⚠️ WARN Ensure files are not too large. (file_size)
  • ⚠️ WARN Font file is 2.72 MB; ideally it should be less than 1.05 MB [code: large-font]
⚠️ WARN Check math signs have the same width. (math_signs_width)
  • ⚠️ WARN The most common width is 582 among a set of 11 math glyphs.
    The following math glyphs have a different width, though:
    width=553: plusminus, approxequal
    width=433: minus
    width=578: equal
    width=600: notequal
    width=583: logicalnot [code: width-outliers]
⚠️ WARN Ensure indic fonts have the Indian Rupee Sign glyph. (rupee)
  • ⚠️ WARN Font is missing the Indian Rupee Sign glyph. Please add a glyph for Indian Rupee Sign (₹) at codepoint U+20B9. [code: missing-rupee]
⚠️ WARN Shapes languages in all GF glyphsets. (googlefonts/glyphsets/shape_languages)
  • ⚠️ WARN Warning language shaping:
Message Languages
Auxiliary orthography codepoints: * ig_Latn (Igbo)
The following auxiliary characters are missing from the font: ɵ
The following auxiliary characters are missing from the font: Ɵ
Auxiliary orthography codepoints: * fi_Latn (Finnish)
The following auxiliary characters are missing from the font: Ǥ
The following auxiliary characters are missing from the font: Ŧ
The following auxiliary characters are missing from the font: Ʒ
The following auxiliary characters are missing from the font: Ǯ
The following auxiliary characters are missing from the font: ǥ
The following auxiliary characters are missing from the font: ŧ
The following auxiliary characters are missing from the font: ʒ
The following auxiliary characters are missing from the font: ǯ
Auxiliary orthography codepoints: * nb_Latn (Norwegian Bokmål)
The following auxiliary characters are missing from the font: Ŧ
The following auxiliary characters are missing from the font: ŧ
Auxiliary orthography codepoints: * de_Latn (German)
The following auxiliary characters are missing from the font: ſ * fr_Latn (French)
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
  • ⚠️ WARN The following separator glyphs are missing:
  • U+2028
  • U+2029 [code: missing-separator-glyphs]
⚠️ WARN Check font follows the Google Fonts vertical metric schema (googlefonts/vertical_metrics)
  • ⚠️ WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.567x (1567) [code: bad-hhea-range]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
  • ℹ️ INFO Hinting filesize impact:
Menbere[wght].ttf
Dehinted Size 2717300
Hinted Size 2717324
Increase 24
Change 0.0 %
ℹ️ INFO Font contains all required tables? (required_tables)
  • ℹ️ INFO This font contains the following optional tables:

    loca
    prep
    GPOS
    GSUB
    gasp
    vhea
    vmtx [code: optional-tables]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
  • ℹ️ INFO These are the ppm ranges declared on the gasp table:

| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |

- Use smoothing along multiple axes with ClearType®
[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
  • ℹ️ INFO "Ethi" [code: dlng-tag]

  • ℹ️ INFO "Ethi, Latn" [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
  • ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.000 [code: version-not-detected]

Summary

🔥 FAIL ✅ PASS ⏩ SKIP ⚠️ WARN ℹ️ INFO
1 116 47 8 8
1% 65% 26% 4% 4%

@emmamarichal emmamarichal merged commit 9cfa68e into main Jun 5, 2025
11 checks passed
@emmamarichal emmamarichal deleted the gftools_packager_ofl_menbere branch June 5, 2025 09:01
@github-project-automation github-project-automation bot moved this from PR GF to In Dev / PR Merged in Fonts Traffic Jam Jun 5, 2025
@emmamarichal emmamarichal moved this from In Dev / PR Merged to In Sandbox in Fonts Traffic Jam Jun 18, 2025
@m4rc1e m4rc1e moved this from In Sandbox to Live in Fonts Traffic Jam Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I New Font II African Mostly west african non-latin and African indigenous scripts II Commissioned Commissioned project to do

Projects

Status: Live

Development

Successfully merging this pull request may close these issues.

Add Menbere

2 participants