Skip to content

Menbere: Version 1.000 added #9345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

yanone
Copy link
Collaborator

@yanone yanone commented Apr 15, 2025

Taken from the upstream repo https://github.com/SorkinType/Menbere at commit SorkinType/Menbere@c602170.

Resolves #8914

PR Checklist:

  • tags are added for NEW FONTS
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@yanone yanone added I New Font II African Mostly west african non-latin and African indigenous scripts II Commissioned Commissioned project to do labels Apr 15, 2025
Copy link

FontBakery report

fontbakery version: 0.13.2

Check results

[17] Menbere[wght].ttf
🔥 FAIL METADATA.pb: Designers are listed correctly on the Google Fonts catalog? googlefonts/metadata/designer_profiles
  • 🔥 FAIL

    Designer Aleme Tadesse still does not have an avatar image. Please provide one.


    [code: missing-avatar]
🔥 FAIL Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
  • 🔥 FAIL

    GF_Phonetics_SinoExt glyphset:

FAIL messages Languages
Mandatory orthography codepoints:
The following mark characters are missing from the font: ̩ yo_Latn (Yoruba)
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: ſ de_Latn (German) and fr_Latn (French)
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: ʻ en_Latn (English)
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: Ǥ
The following auxiliary characters are missing from the font: Ŧ
The following auxiliary characters are missing from the font: Ʒ
The following auxiliary characters are missing from the font: Ǯ
The following auxiliary characters are missing from the font: ǥ
The following auxiliary characters are missing from the font: ŧ
The following auxiliary characters are missing from the font: ʒ
The following auxiliary characters are missing from the font: ǯ fi_Latn (Finnish)
Auxiliary orthography codepoints:
Shaper didn't attach acutecomb to Uogonek when shaping the text 'Ų́'
Shaper didn't attach tildecomb to Uogonek when shaping the text 'Ų̃' lt_Latn (Lithuanian)
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: Ŧ
The following auxiliary characters are missing from the font: ŧ nb_Latn (Norwegian Bokmål)
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: ɵ
The following auxiliary characters are missing from the font: Ɵ ig_Latn (Igbo)
Auxiliary orthography codepoints:
The following auxiliary characters are missing from the font: e̩
The following auxiliary characters are missing from the font: E̩
The following auxiliary characters are missing from the font: é̩
The following auxiliary characters are missing from the font: É̩
The following auxiliary characters are missing from the font: è̩
The following auxiliary characters are missing from the font: È̩
The following auxiliary characters are missing from the font: ê̩
The following auxiliary characters are missing from the font: Ê̩
The following auxiliary characters are missing from the font: ě̩
The following auxiliary characters are missing from the font: Ě̩
The following auxiliary characters are missing from the font: o̩
The following auxiliary characters are missing from the font: O̩
The following auxiliary characters are missing from the font: ó̩
The following auxiliary characters are missing from the font: Ó̩
The following auxiliary characters are missing from the font: ò̩
The following auxiliary characters are missing from the font: Ò̩
The following auxiliary characters are missing from the font: ô̩
The following auxiliary characters are missing from the font: Ô̩
The following auxiliary characters are missing from the font: ǒ̩
The following auxiliary characters are missing from the font: Ǒ̩
The following auxiliary characters are missing from the font: s̩
The following auxiliary characters are missing from the font: S̩ yo_Latn (Yoruba)
[code: warning-language-shaping]
⚠️ WARN Ensure files are not too large. file_size
  • ⚠️ WARN

    Font file is 2.5Mb; ideally it should be less than 1.0Mb


    [code: large-font]
⚠️ WARN Detect any interpolation issues in the font. interpolation_issues
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour order differs in glyph 'hungarumlaut': [0, 1] in wght=400, [1, 0] in wght=100.

- Contour order differs in glyph 'uni030F.case': [0, 1] in wght=100, [1, 0] in wght=700.

- Contour 0 start point differs in glyph 'exclamdown' between location wght=400 and location wght=100

- Contour 0 in glyph 'exclamdown': becomes underweight between wght=400 and wght=100.

- Contour order differs in glyph 'guillemotleft': [0, 1] in wght=100, [1, 0] in wght=700.

- Contour order differs in glyph 'quotedbl': [0, 1] in wght=400, [1, 0] in wght=100.

- Contour order differs in glyph 'quotedbl': [0, 1] in wght=100, [1, 0] in wght=700.

- Contour 0 start point differs in glyph 'multiply' between location wght=100 and location wght=700

- Contour 0 in glyph 'uni1210': becomes underweight between wght=100 and wght=700.

- Contour order differs in glyph 'colon': [0, 1] in wght=400, [1, 0] in wght=100.

- 6 more.

Use -F or --full-lists to disable shortening of long lists.

[code: interpolation-issues]
⚠️ WARN Check math signs have the same width. math_signs_width
  • ⚠️ WARN

    The most common width is 582 among a set of 5 math glyphs.
    The following math glyphs have a different width, though:

Width = 578: equal

Width = 583: logicalnot

Width = 553: plusminus, approxequal

Width = 433: minus

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs unreachable_glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- overscorecomb

- space_sm5

[code: unreachable-glyphs]

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets. googlefonts/article/images
  • ⚠️ WARN

    Article page lacks visual assets.


    [code: missing-visual-asset]
⚠️ WARN METADATA.pb: Check for primary_script googlefonts/metadata/primary_script
  • ⚠️ WARN

    METADATA.pb: primary_script field should be 'Ethi' but is missing.


    [code: missing-primary-script]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, tifinagh, math, cherokee
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, old-permic, syriac, tai-le, canadian-aboriginal, malayalam, todhri, coptic, duployan, math, hebrew
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+030F COMBINING DOUBLE GRAVE ACCENT: not included in any glyphset definition 85 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: ethiopic, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Check font follows the Google Fonts vertical metric schema googlefonts/vertical_metrics
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.567x (1567)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths superfamily/list
  • ℹ️ INFO

    ofl/menbere


    [code: family-path]
ℹ️ INFO Show hinting filesize impact. hinting_impact
  • ℹ️ INFO

    Hinting filesize impact:

ofl/menbere/Menbere[wght].ttf
Dehinted Size 2.5Mb
Hinted Size 2.5Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables? required_tables
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
  • ℹ️ INFO

    Ethi


    [code: dlng-tag]

  • ℹ️ INFO

    Ethi, Latn


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 8 40 8 178 0
0% 0% 1% 3% 17% 3% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

dest_file: "article/ARTICLE.en_us.html"
}
branch: "main"
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

primary script missing? @yanone

dest_file: "article/ARTICLE.en_us.html"
}
branch: "main"
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • stroke: "SANS_SERIF"

@emmamarichal
Copy link
Collaborator

emmamarichal commented Apr 16, 2025

@yanone some of these fails could be solved:

Fontbakery report:

  • 🔥 FAIL METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
    -> Bios for upcoming Menbere and Agbalumo #9140
  • 🔥 FAIL Shapes languages in all GF glyphsets.
    -> Would be nice to solve at least the first one: yo_Latn (Yoruba) by adding anchors to ̩
  • ⚠️ WARN Detect any interpolation issues in the font.
    -> colon/guillemotleft/hungarumlaut/quotedbl/uni030F/uni030F.case/exclamdown/multiply/uni1345/exclamdown/uni1210/uni1345
Screenshot 2025-04-16 at 14 05 50
  • ⚠️ WARN METADATA.pb: Check for primary_script
    -> we need to add 'Ethi'

  • ⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
    -> It's a commissioned font, so we need images for the article

  • ⚠️ WARN Check font follows the Google Fonts vertical metric schema
    -> Is there a specific reason why the typeface doesn't follow the specs for the v-metrics?

  • ⚠️ WARN Check font contains no unreachable glyphs
    -> This WARN can be avoid by just un-export the two concerned glyphs

@emmamarichal
Copy link
Collaborator

emmamarichal commented Apr 16, 2025

Some other outlines issues:

-Spacing issue?

Screen.Recording.2025-04-16.at.14.25.58.mov
Screenshot 2025-04-16 at 14 25 23 Screenshot 2025-04-16 at 14 25 27 Screenshot 2025-04-16 at 14 26 25 Screenshot 2025-04-16 at 14 26 34 Screenshot 2025-04-16 at 14 27 25

For these ones, it's not a mistake, just maybe something in the design that isn't logical, in terms of alignment.

Screen.Recording.2025-04-16.at.14.29.06.mov
Screen.Recording.2025-04-16.at.14.29.23.mov

@yanone yanone marked this pull request as draft April 23, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I New Font II African Mostly west african non-latin and African indigenous scripts II Commissioned Commissioned project to do
Projects
Status: PR GF
Development

Successfully merging this pull request may close these issues.

Add Menbere
2 participants