-
Notifications
You must be signed in to change notification settings - Fork 2.8k
families.csv: Add test VF tags #9897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Open Sans,"wght,wdth@600,75",/Expressive/Loud,21 | ||
| Open Sans,"wght,wdth@600,100",/Expressive/Loud,15 | ||
| Open Sans,"wght,wdth@800,75",/Expressive/Loud,80 | ||
| Open Sans,"wght,wdth@800,100",/Expressive/Loud,75 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the intended loudness at weight 599?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. Now I wonder if this could/should be modelled by deltas?
wdth 75 => +6
wdth 100 => +0
wght 600 => +15
wght 800 => +75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I still wonder what wght 599 scores, it would be a bit odd if it jumped directly from 15 to 0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the intended loudness at weight 599?
If we let the RBF interpolation do its thing, we'll get a value less than 10. This is what happens in my demo, https://google.github.io/fonts/vf-tag-demo2.html adjust the weight slider and you'll see you'll get values less than the minimum tag, which is also 10.
If we don't like this behaviour, we should instead be defining the coordinate when the score is 0.
We could also treat it like a designspace aka don't allow extrapolation so it will literally be 0 for any value outside the range of 600-800.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this pr in the tagger may make more sense for why I picked the values that I did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC we ruled out RBF and planned to use "normal" VF interpolation, @nyshadhr9 is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should instead be defining the coordinate when the score is 0
My intuition is this may be what we want, making triangles of influence, say loud is 0 at 400, high at 900, in traditional VF style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's right - we will go with linear/multilinear interpolation.
Marc and I talked offline. Looks like supporting something like a step function - loud between 600 and 800 but not below or above those values - might be helpful too. I think we should be able to support that, but we need to come up with a way to specify this when assigning tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a new demo that uses linear interpolation and doesn't allow extrapolation, https://google.github.io/fonts/vf-tag-demo-linear.html. Imo this feels like the right direction. People adding the tags should also be thinking "when does 0 start for this tag"
@nyshadhr9 This PR tests two font families: Maven Pro and Open Sans. Open Sans has two axes that influence how “loud” the family appears, which is why 4 tags are required. Maven Pro, on the other hand, only has a weight axis, so only 2 tags are needed.
If I were tagging a family with 3 axes that affect the Loud category, I’d need to add at least 8 positions. Does this logic make sense?