Skip to content

[core] feat: FakeApiClient supports reading data from remote storage #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreyMarkinPPC merged 1 commit into from
Sep 26, 2025
Merged

[core] feat: FakeApiClient supports reading data from remote storage #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libs/core/garf_core/api_clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@
import csv
import json
import os
import pathlib
from collections.abc import Sequence
from typing import Any, Union

import pydantic
import requests
import smart_open
from typing_extensions import TypeAlias, override

from garf_core import exceptions, query_editor
Expand Down Expand Up @@ -124,7 +124,7 @@ def from_json(cls, file_location: str | os.PathLike[str]) -> FakeApiClient:
GarfApiError: When file with data not found.
"""
try:
with pathlib.Path.open(file_location, 'r', encoding='utf-8') as f:
with smart_open.open(file_location, 'r', encoding='utf-8') as f:
data = json.load(f)
return FakeApiClient(data)
except FileNotFoundError as e:
Expand All @@ -144,7 +144,7 @@ def from_csv(cls, file_location: str | os.PathLike[str]) -> FakeApiClient:
GarfApiError: When file with data not found.
"""
try:
with pathlib.Path.open(file_location, 'r', encoding='utf-8') as f:
with smart_open.open(file_location, 'r', encoding='utf-8') as f:
reader = csv.DictReader(f)
data = []
for row in reader:
Expand Down
Loading