This repository was archived by the owner on Oct 8, 2024. It is now read-only.
Add missing "rows" option in _save_config#34
Open
SASUPERNOVA wants to merge 1 commit intogoogle:masterfrom
Open
Add missing "rows" option in _save_config#34SASUPERNOVA wants to merge 1 commit intogoogle:masterfrom
SASUPERNOVA wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
What's the status of this PR and #35? I tried using gif-for-cli because it looks interesting, but it seems currently completely broken. It looks like all that needs to be done is for @SASUPERNOVA to sign the CLA, correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
_save_configis not includingrowsoption in its iteration. As a result,scale_heightbecomes 0, which in turn causes issue Can't use gif-for-cli (Float division by zero on execute.py). This patch includesrowsoption to fix this issue.