Remove ECCParameters.Point initialization #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed initialization of ECCParameters.Point for various key sizes.
brandonweeks
force-pushed
the
ecc-point
branch
from
15e38e3 to
22d746a
Compare
brandonweeks
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed initialization of ECCParameters.Point for various key sizes, testing #303.
The TPM spec is a tough read, but I don't think these values are needed when creating a key on the TPM.
Coverage is via: https://github.com/google/go-attestation/blob/master/attest/application_key_test.go#L81, which ensures the P521 keys work.