Support OCI layout tarballs in crane load#2320
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
Signed-off-by: Haihan Jiang <haihanj99@gmail.com>
Haihan-Jiang
marked this pull request as ready for review
May 24, 2026 12:32
Contributor
Author
|
This is ready for review. The change lets crane load accept OCI layout tarballs through the existing push path, with coverage in pkg/crane. The visible checks are green. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2320 +/- ##
==========================================
- Coverage 56.91% 56.87% -0.04%
==========================================
Files 165 165
Lines 11362 11428 +66
==========================================
+ Hits 6467 6500 +33
- Misses 4134 4153 +19
- Partials 761 775 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| tr := tar.NewReader(f) | ||
| for { | ||
| header, err := tr.Next() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2109.
Summary
crane.Loadfall back from Docker tarball parsing to single-image OCI layout tarballscrane pushhelp text now that non-directory inputs can be Docker or OCI layout tarballscrane.SaveOCITesting
go test ./pkg/crane -run TestCraneLoadOCILayoutTarball -count=1go test ./pkg/crane ./cmd/crane/cmd -count=1go test ./...