Skip to content

crane: allow empty label values - #2378

Open
vigneshakaviki wants to merge 5 commits into
google:mainfrom
vigneshakaviki:fix/crane-empty-label-value
Open

crane: allow empty label values#2378
vigneshakaviki wants to merge 5 commits into
google:mainfrom
vigneshakaviki:fix/crane-empty-label-value

Conversation

@vigneshakaviki

Copy link
Copy Markdown
Contributor

Summary

  • allow crane mutate to retain labels whose value is empty
  • cover empty label values through an in-memory registry round trip

Fixes #2376

Testing

  • ./hack/presubmit.sh
  • go test -race ./...
  • go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.11.0 run
  • go run golang.org/x/tools/cmd/goimports@v0.48.0 -d cmd/crane/cmd/mutate.go cmd/crane/cmd/mutate_test.go

@google-cla

google-cla Bot commented Jul 26, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.55%. Comparing base (af2603f) to head (9075425).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2378      +/-   ##
==========================================
+ Coverage   57.30%   57.55%   +0.24%     
==========================================
  Files         166      166              
  Lines       11527    11525       -2     
==========================================
+ Hits         6606     6633      +27     
+ Misses       4142     4090      -52     
- Partials      779      802      +23     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Subserial

Copy link
Copy Markdown
Contributor

The windows runner issues are transient, and we should address them in a different PR. Could you remove the changes from this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crane: allow empty label values

3 participants