crane: allow empty label values - #2378
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2378 +/- ##
==========================================
+ Coverage 57.30% 57.55% +0.24%
==========================================
Files 166 166
Lines 11527 11525 -2
==========================================
+ Hits 6606 6633 +27
+ Misses 4142 4090 -52
- Partials 779 802 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The windows runner issues are transient, and we should address them in a different PR. Could you remove the changes from this PR? |
Summary
crane mutateto retain labels whose value is emptyFixes #2376
Testing
./hack/presubmit.shgo test -race ./...go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.11.0 rungo run golang.org/x/tools/cmd/goimports@v0.48.0 -d cmd/crane/cmd/mutate.go cmd/crane/cmd/mutate_test.go