Interpreter Stack Profiler flag #799
Open
+105
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage: JSONNET_STACK_PROFILE=stacks.out jsonnet main.jsonnet cat stacks.out | flamegraph.pl --hash > flamegraph.svg
Rudimentary stack profiler
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
B13rg
commented
Apr 6, 2025
| @@ -281,6 +286,15 @@ type interpreter struct { | |||
| stack callStack | |||
|
|
|||
| evalHook EvalHook | |||
|
|
|||
| profilerOpts StackProfilerOpts | |||
There was a problem hiding this comment.
When running the govet linter, I am seeing the following issue:
interpreter.go:267:18: fieldalignment: struct with 128 pointer bytes could be 104 (govet)
type interpreter struct {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #529
I have attempted to finish what was started by @igorwwwwwwwwwwwwwwwwwwww .
To not use global variable, I added the field
profilerOptsto the VM and interpreter objects.The
StackProfilerOptsobject stores what was the global variables.As part of adding the field, I simplified the function calls of
evaluate,evaluateStream, andevaluateMultito just take the VM object instead of individual parameters.I am unsure if it is the right type, or if it should be a
*StackProfilerOptsinstead.Thanks!