-
Notifications
You must be signed in to change notification settings - Fork 129
chore: update golang.org/x/tools to v0.36.0 to resolve the build error #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you fix the build failure? It seems it doesn't want go 1.23.0 format. Maybe we need to upgrade the github actions env to higher go versions first / at the same PR. |
|
I tested this pull request in the following pull request and confirmed CI passed. If we upgrade golangci-lint to the latest version, we need to fix code. https://github.com/suzuki-shunsuke/go-licenses/actions/runs/17544642696/job/49823170134 DetailsSo I gave up the latest version and updated to v1.64.8 |
``` Error: invalid version string 'v1.64.8', golangci-lint v1 is not supported by golangci-lint-action >= v7. ```
f92485d to
c12c97a
Compare
|
Thanks for the fix! I'm going to release another v2 version with the patch. |
Close #333
I've confirmed the build succeeded.
go install .