[Quote V5 Support] Implement TDX Quote V5 Proto to Bytes Conversion#83
Merged
Sourabh-25 merged 1 commit intogoogle:mainfrom Jan 4, 2026
Merged
[Quote V5 Support] Implement TDX Quote V5 Proto to Bytes Conversion#83Sourabh-25 merged 1 commit intogoogle:mainfrom
Sourabh-25 merged 1 commit intogoogle:mainfrom
Conversation
vbalain
reviewed
Dec 29, 2025
vbalain
reviewed
Dec 29, 2025
vbalain
reviewed
Dec 29, 2025
5118719 to
3e20e83
Compare
vbalain
reviewed
Dec 30, 2025
19fd3bf to
76e212d
Compare
vbalain
reviewed
Dec 31, 2025
vbalain
reviewed
Dec 31, 2025
vbalain
reviewed
Dec 31, 2025
6e88e6d to
896a175
Compare
vbalain
reviewed
Dec 31, 2025
vbalain
reviewed
Dec 31, 2025
896a175 to
eef9dcf
Compare
vbalain
approved these changes
Jan 1, 2026
jrjatin
approved these changes
Jan 2, 2026
eef9dcf to
1172eb9
Compare
1172eb9 to
58a3ad4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the functionality to serialize the TDX Quote Format V5 protobuf messages back into their raw little-endian ABI byte format. This complements the byte-to-proto parsing added in the previous PR.
NOTE: Stacked PR: This builds on top of my previous pending PR . Please ignore the first commits and only review the final commit which implements
quoteToAbiBytes.Key changes:
Proto to Bytes Serialization:
QuoteToAbiBytesto dispatch toquoteToAbiBytesV5forpb.QuoteV5types.quoteToAbiBytesV5: Converts the mainpb.QuoteV5message to bytes.TdQuoteBodyDescriptorToAbiBytes: Converts thepb.TDQuoteBodyDescriptormessage to bytes.TdQuoteBodyV5ToAbiBytes: Converts thepb.TDQuoteBodyV5message to bytes, handling differences between TDX 1.0 and 1.5 body types.Unit Tests:
abi_test.goto verify the correctness of the proto-to-bytes conversions.QuoteToAbiBytes(QuoteToProto(test.RawQuoteV5))match the originaltest.RawQuoteV5.TdQuoteBodyDescriptorToAbiBytesandTdQuoteBodyV5ToAbiBytesfunctions inTestNilToAbiBytesConversionsandTestInvalidConversionsToAbiBytes.