[Quote V5 Support] Determine if relaunch is required for TD #89
Open
Sourabh-25 wants to merge 3 commits intogoogle:mainfrom
Open
[Quote V5 Support] Determine if relaunch is required for TD #89Sourabh-25 wants to merge 3 commits intogoogle:mainfrom
Sourabh-25 wants to merge 3 commits intogoogle:mainfrom
Conversation
Sourabh-25
force-pushed
the
relaunch-v5
branch
from
e5e3fe7 to
eaa8480
Compare
vbalain
reviewed
Feb 10, 2026
| tdxModuleTcbStatus = tdxModuleFound.TcbStatus | ||
| } | ||
|
|
||
| if teeTcbSvn2 != nil && (tdxModuleTcbStatus == pcs.TcbComponentStatusOutOfDate || tdxModuleTcbStatus == pcs.TcbComponentStatusOutOfDateConfigurationNeeded) { |
Collaborator
There was a problem hiding this comment.
nit: let's move it to a separate function so that it's clear tee tcb svn2 is used for relaunch check
vbalain
reviewed
Feb 10, 2026
| if teeTcbSvn2 != nil && (tdxModuleTcbStatus == pcs.TcbComponentStatusOutOfDate || tdxModuleTcbStatus == pcs.TcbComponentStatusOutOfDateConfigurationNeeded) { | ||
| latestTcbLevel := tcbInfo.TcbLevels[0] | ||
|
|
||
| if teeTcbSvn2[1] == 0 { |
Collaborator
There was a problem hiding this comment.
Let's add a comment explaining a little bit about what is being done here.
vbalain
reviewed
Feb 23, 2026
| } | ||
|
|
||
| func readTcbInfoTcbStatus(tcbInfo pcs.TcbInfo, tdQuoteBody any, pckCertExtensions *pcs.PckExtensions) (pcs.TcbLevel, error) { | ||
| func readTcbInfoTcbStatus(tcbInfo pcs.TcbInfo, tdQuoteBody any, pckCertExtensions *pcs.PckExtensions) (pcs.TcbLevel, pcs.TcbLevel, error) { |
Collaborator
There was a problem hiding this comment.
Could you explain why two pcs.TcbLevel are required in return arguments?
Also, a comment to clarify these output arguments would be nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update TCB verification to align with Intel DCAP logic for TDX Quote V5. This enables the "Relaunch Advised" check by utilizing the new
teeTcbSvn2field to determine if a guest relaunch would resolve an OutOfDate status.Changes
getTeeTcbSvnto extractteeTcbSvnandteeTcbSvn2from both V4 and V5 quote bodies.readTcbInfoTcbStatusto return both Platform TCB and TDX Module levels independently.tdxModuleTcbStatusisOutOfDate.teeTcbSvn2components against the latest TCB levels.isConfigurationNeededto consolidate complex TCB status checks.