Skip to content

[launcher] Update cs host directory permission #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkl73 merged 1 commit into from
May 21, 2025
Merged

[launcher] Update cs host directory permission #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion launcher/container_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ func (r *ContainerRunner) fetchAndWriteToken(ctx context.Context) error {
// retry specifies the refresher goroutine's retry policy.
func (r *ContainerRunner) fetchAndWriteTokenWithRetry(ctx context.Context,
retry func() *backoff.ExponentialBackOff) error {
if err := os.MkdirAll(launcherfile.HostTmpPath, 0744); err != nil {
if err := os.MkdirAll(launcherfile.HostTmpPath, 0755); err != nil {
return err
}
duration, err := r.refreshToken(ctx)
Expand Down
6 changes: 3 additions & 3 deletions launcher/container_runner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ func TestRefreshToken(t *testing.T) {
logger: logging.SimpleLogger(),
}

if err := os.MkdirAll(launcherfile.HostTmpPath, 0744); err != nil {
if err := os.MkdirAll(launcherfile.HostTmpPath, 0755); err != nil {
t.Fatalf("Error creating host token path directory: %v", err)
}

Expand Down Expand Up @@ -205,7 +205,7 @@ func TestRefreshTokenWithSignedContainerCacheEnabled(t *testing.T) {
logger: logging.SimpleLogger(),
}

if err := os.MkdirAll(launcherfile.HostTmpPath, 0744); err != nil {
if err := os.MkdirAll(launcherfile.HostTmpPath, 0755); err != nil {
t.Fatalf("Error creating host token path directory: %v", err)
}

Expand Down Expand Up @@ -245,7 +245,7 @@ func TestRefreshTokenWithSignedContainerCacheEnabled(t *testing.T) {
}

func TestRefreshTokenError(t *testing.T) {
if err := os.MkdirAll(launcherfile.HostTmpPath, 0744); err != nil {
if err := os.MkdirAll(launcherfile.HostTmpPath, 0755); err != nil {
t.Fatalf("Error creating host token path directory: %v", err)
}

Expand Down
2 changes: 1 addition & 1 deletion launcher/launcher/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func main() {
return
}

if err := os.MkdirAll(launcherfile.HostTmpPath, 0744); err != nil {
if err := os.MkdirAll(launcherfile.HostTmpPath, 0755); err != nil {
logger.Error(fmt.Sprintf("failed to create %s: %v", launcherfile.HostTmpPath, err))
}

Expand Down
Loading