Skip to content

googleapis_auth: test cleanup#716

Merged
kevmoo merged 2 commits intomasterfrom
test_cleanup
Feb 17, 2026
Merged

googleapis_auth: test cleanup#716
kevmoo merged 2 commits intomasterfrom
test_cleanup

Conversation

@kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Feb 17, 2026

Modernized Assertions:

  • Refactored numerous tests to use isA().having() for more precise and readable error checks.
  • Replaced deprecated or verbose matcher patterns (e.g., expect(a, equals(b)) -> expect(a, b)).
  • Standardized top-level matchers in test_utils.dart as const TypeMatcher.

Refined Test Structure:

  • Removed single, redundant top-level group calls from across the test suite (adc_test.dart, iam_signer_test.dart, json_test.dart, pem_test.dart, etc.).
  • Applied PascalCase to groups representing classes (e.g., group('AccessToken', ...)).
  • Improved test descriptions to clearly state expected behavior (e.g., 'throws on invalid server response').

Cleaner Code:

  • Moved to public API imports where appropriate.
  • Standardized the placement of named parameters across all modernized tests.

All 107 tests passed after these changes. I'm ready for any further instructions!

Modernized Assertions:
   * Refactored numerous tests to use isA<T>().having() for more precise and readable error checks.
   * Replaced deprecated or verbose matcher patterns (e.g., expect(a, equals(b)) -> expect(a, b)).
   * Standardized top-level matchers in test_utils.dart as const TypeMatcher<T>.

Refined Test Structure:
   * Removed single, redundant top-level group calls from across the test suite (adc_test.dart, iam_signer_test.dart, json_test.dart, pem_test.dart, etc.).
   * Applied PascalCase to groups representing classes (e.g., group('AccessToken', ...)).
   * Improved test descriptions to clearly state expected behavior (e.g., 'throws on invalid server response').

Cleaner Code:
   * Moved to public API imports where appropriate.
   * Standardized the placement of named parameters across all modernized tests.

  All 107 tests passed after these changes. I'm ready for any further instructions!
@github-actions
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
googleapis_auth Breaking 2.0.0 2.1.0-wip 2.1.0-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Unused Dependencies ✔️
Package Status
googleapis_auth ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

@kevmoo kevmoo merged commit e6d0a9c into master Feb 17, 2026
32 checks passed
@kevmoo kevmoo deleted the test_cleanup branch February 17, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant