Conversation
Modernized Assertions:
* Refactored numerous tests to use isA<T>().having() for more precise and readable error checks.
* Replaced deprecated or verbose matcher patterns (e.g., expect(a, equals(b)) -> expect(a, b)).
* Standardized top-level matchers in test_utils.dart as const TypeMatcher<T>.
Refined Test Structure:
* Removed single, redundant top-level group calls from across the test suite (adc_test.dart, iam_signer_test.dart, json_test.dart, pem_test.dart, etc.).
* Applied PascalCase to groups representing classes (e.g., group('AccessToken', ...)).
* Improved test descriptions to clearly state expected behavior (e.g., 'throws on invalid server response').
Cleaner Code:
* Moved to public API imports where appropriate.
* Standardized the placement of named parameters across all modernized tests.
All 107 tests passed after these changes. I'm ready for any further instructions!
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Unused Dependencies ✔️
For details on how to fix these, see dependency_validator. This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernized Assertions:
Refined Test Structure:
Cleaner Code:
All 107 tests passed after these changes. I'm ready for any further instructions!