Skip to content

Move signBlob to a function, remove IAMSigner class#717

Merged
kevmoo merged 4 commits intomasterfrom
drop_signer_class
Feb 18, 2026
Merged

Move signBlob to a function, remove IAMSigner class#717
kevmoo merged 4 commits intomasterfrom
drop_signer_class

Conversation

@kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Feb 17, 2026

Fix up the docs

@kevmoo kevmoo requested a review from demolaf February 17, 2026 20:21
@github-actions
Copy link

github-actions bot commented Feb 17, 2026

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
googleapis_auth Non-Breaking 2.0.0 2.1.0 2.0.1 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Unused Dependencies ✔️
Package Status
googleapis_auth ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

@kevmoo
Copy link
Collaborator Author

kevmoo commented Feb 17, 2026

Okay @demolaf – I cleaned up a bunch. Hopefully the firebase bits won't be broken.

@kevmoo
Copy link
Collaborator Author

kevmoo commented Feb 18, 2026

@demolaf – here is the draft PR that builds on this invertase/dart_firebase_admin#170

kevmoo added a commit to kevmoo/dart_firebase_admin that referenced this pull request Feb 18, 2026
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:_discoveryapis_commons 1.0.8-wip WIP (no publish necessary)
package:discoveryapis_generator 1.1.0-wip WIP (no publish necessary)
package:googleapis 16.0.0 already published at pub.dev
package:googleapis_auth 2.1.0 ready to publish googleapis_auth-v2.1.0
package:googleapis_beta 9.1.0-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@kevmoo kevmoo merged commit 3ebe7d1 into master Feb 18, 2026
32 checks passed
@kevmoo kevmoo deleted the drop_signer_class branch February 18, 2026 17:12
demolaf added a commit to invertase/dart_firebase_admin that referenced this pull request Feb 18, 2026
* Update packages for googleapis_auth breaking changes

Accommodate breaking changes from googleapis_auth, specifically the removal of the
`serviceAccountCredentials` getter and the refactoring of cryptographic signing.
- Update `AuthClient.sign()` usages across dart_firebase_admin and googleapis_storage.
  The method now returns a `Future<String>` (base64-encoded signature) instead of
  an object with a `signedBlob` property.
- Explicitly pass `serviceAccountCredentials` into `sign()` invocations where available
  to maintain local RSA signing capabilities.
- Remove `serviceAccountCredentials` overrides from EmulatorClient implementations
  in dart_firebase_admin, googleapis_storage, and googleapis_firestore.
- Update Compute Engine environment detection in FunctionsRequestHandler to check
  internal credential options instead of the removed AuthClient.serviceAccountCredentials.
- Delete local AuthExtension helpers in dart_firebase_admin and googleapis_storage,
  migrating to the newly provided AuthClientSigningExtension methods.
- Update authClient.getServiceAccountEmail usages from a getter to a method invocation.

* OVERRIDES for in-flight PR

Will replace when google/googleapis.dart#717 lands

* test: fix functions test mock for metadata server email resolution

---------

Co-authored-by: Ademola Fadumo <48495111+demolaf@users.noreply.github.com>
demolaf added a commit to invertase/dart_firebase_admin that referenced this pull request Feb 19, 2026
…pis (#171)

* Update packages for googleapis_auth breaking changes

Accommodate breaking changes from googleapis_auth, specifically the removal of the
`serviceAccountCredentials` getter and the refactoring of cryptographic signing.
- Update `AuthClient.sign()` usages across dart_firebase_admin and googleapis_storage.
  The method now returns a `Future<String>` (base64-encoded signature) instead of
  an object with a `signedBlob` property.
- Explicitly pass `serviceAccountCredentials` into `sign()` invocations where available
  to maintain local RSA signing capabilities.
- Remove `serviceAccountCredentials` overrides from EmulatorClient implementations
  in dart_firebase_admin, googleapis_storage, and googleapis_firestore.
- Update Compute Engine environment detection in FunctionsRequestHandler to check
  internal credential options instead of the removed AuthClient.serviceAccountCredentials.
- Delete local AuthExtension helpers in dart_firebase_admin and googleapis_storage,
  migrating to the newly provided AuthClientSigningExtension methods.
- Update authClient.getServiceAccountEmail usages from a getter to a method invocation.

* OVERRIDES for in-flight PR

Will replace when google/googleapis.dart#717 lands

* test: fix functions test mock for metadata server email resolution

* feat: add extension methods for FirebaseApp to handle service account email and signing

* chore: bump dart_firebase_admin to 0.5.0 and googleapis_auth dependency to 2.1.0

* chore: update changelog

---------

Co-authored-by: Kevin Moore <kevmoo@google.com>
demolaf added a commit to invertase/dart_firebase_admin that referenced this pull request Feb 19, 2026
… requests (#169)

* test: firebase app tests and fixes

* chore: code cleanup

* feat: add FirebaseUserAgentClient to track SDK usage

* Update packages for googleapis_auth breaking changes

Accommodate breaking changes from googleapis_auth, specifically the removal of the
`serviceAccountCredentials` getter and the refactoring of cryptographic signing.
- Update `AuthClient.sign()` usages across dart_firebase_admin and googleapis_storage.
  The method now returns a `Future<String>` (base64-encoded signature) instead of
  an object with a `signedBlob` property.
- Explicitly pass `serviceAccountCredentials` into `sign()` invocations where available
  to maintain local RSA signing capabilities.
- Remove `serviceAccountCredentials` overrides from EmulatorClient implementations
  in dart_firebase_admin, googleapis_storage, and googleapis_firestore.
- Update Compute Engine environment detection in FunctionsRequestHandler to check
  internal credential options instead of the removed AuthClient.serviceAccountCredentials.
- Delete local AuthExtension helpers in dart_firebase_admin and googleapis_storage,
  migrating to the newly provided AuthClientSigningExtension methods.
- Update authClient.getServiceAccountEmail usages from a getter to a method invocation.

* OVERRIDES for in-flight PR

Will replace when google/googleapis.dart#717 lands

* test: fix functions test mock for metadata server email resolution

* feat: add extension methods for FirebaseApp to handle service account email and signing

* chore: bump dart_firebase_admin to 0.5.0 and googleapis_auth dependency to 2.1.0

* chore: update changelog

* chore: code cleanup

* fix ci

* feat: add X-Goog-Api-Client header

---------

Co-authored-by: Kevin Moore <kevmoo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants