Add CombineTo<R>() parameters generator
#4727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@derekmauro As soon as I understand you are the one of maintainers. Can you please review this feature and help to bring it faster to the release? We really need it in GROMACS. |
…pe transformations
`CombineTo<R>()` allows to construct the required type directly from combined arguments. As it would be a composition of `ConvertGenerator()` and `Combine()`, but without `std::tuple` in between.
|
Rebased onto main and adapted to use the new version of ConvertGenerator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CombineTo()allows the user to combine two or more sequences to produce values of a Cartesian product of those sequences' elements converted to the required type. The behavior of this function is the same as already implemented and well-knownCombine().CombineTo()allows to use struct-parametrized tests directly instead of dealing with tuples. Maybe the better naming for this function isCombineAs()The behavior of other functions have not been changed (according to the tests passing). The additional basic test cases are provided for this feature. Feel free to give me some ideas to make better coverage.
Dear maintainers, please note, this feature is very necessary in GROMACS project and we want it as soon as possible. I see that 1.16.0 has been released. Maybe it is possible to make the new release faster and include this feature in the upcoming release somehow? Or maybe backport it as 1.16.1 too?