Open
Conversation
This is a small patch to avoid strict aliasing issues manifested in GCC I came across a while ago. The test case was complex and the failing assertion with a matcher was present only with `-O3`, so I don't have a standalone test. However, I manually confirmed adding `-fno-strict-aliasing` fixed the issue before this patch, and `-O3` behaved as intended after this patch without turning strict-aliasing off. There is a similar previous change in google@50ce520. For the relevant clause from the C++17 standard, refer to below note from https://timsong-cpp.github.io/cppwp/n4659/basic.life#8: > [ Note: If these conditions are not met, a pointer to the new object can be obtained from a pointer that represents the address of its storage by calling std::launder ([support.dynamic]). — end note ]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small patch to avoid strict aliasing issues manifested in GCC I came across a while ago.
The test case was complex and the failing assertion with a matcher was present only with
-O3, so I don't have a standalone test. However, I manually confirmed adding-fno-strict-aliasingfixed the issue before this patch, and-O3behaved as intended after this patch without turning strict-aliasing off.There is a similar previous change in 50ce520.
For the relevant clause from the C++17 standard, refer to below note from https://timsong-cpp.github.io/cppwp/n4659/basic.life#8: