gtest.cc: declare fail_if_no_test_linked flag#4898
Open
ngie-eign wants to merge 1 commit intogoogle:mainfrom
Open
gtest.cc: declare fail_if_no_test_linked flag#4898ngie-eign wants to merge 1 commit intogoogle:mainfrom
ngie-eign wants to merge 1 commit intogoogle:mainfrom
Conversation
Clang's -Wmissing-variable-declarations flags this as an issue since the flag is only used in `gtest.cc`. Declare the flag beforehand to ensure that the variable scope is properly limited to `gtest.cc`. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
freebsd-git
pushed a commit
to freebsd/freebsd-src
that referenced
this pull request
Jan 29, 2026
Clang's -Wmissing-variable-declarations flags this as an issue since the flag is only used in `gtest.cc`. Declare the flag beforehand to ensure that the variable scope is properly limited to `gtest.cc`. MFC after: 1 week MFC with: 4633322 Ref: google/googletest#4898
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang's
-Wmissing-variable-declarationsflag flags this as an issue since the flag is only used ingtest.cc. Declare the flag beforehand ingtest.ccto tell the compiler that the variable scope is limited togtest.cc.Closes: #4897