Fix ASSERT_FALSE to preserve const-correct boolean evaluation#4902
Open
Abhi10111 wants to merge 1 commit intogoogle:mainfrom
Open
Fix ASSERT_FALSE to preserve const-correct boolean evaluation#4902Abhi10111 wants to merge 1 commit intogoogle:mainfrom
Abhi10111 wants to merge 1 commit intogoogle:mainfrom
Conversation
…ead to differing failure results" Signed-off-by: Abhi10111 <abhishekaggarwal896@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
ASSERT_FALSE negates the expression before passing it to AssertionResult,
which forces early boolean conversion and bypasses the
AssertionResult(const T&) constructor. This leads to inconsistent overload
resolution compared to ASSERT_TRUE when types define both const and
non-const operator bool().
Solution:
Both ASSERT_TRUE and ASSERT_FALSE now pass the original expression to
AssertionResult, allowing const-correct evaluation. The expected boolean
value is compared after AssertionResult construction, restoring symmetric
behavior.
Tests:
Added a regression test demonstrating the inconsistency with a type that
defines both const and non-const operator bool(). The test fails on main
and passes with this change.
Fixes #4832