Fix null pointer crash in ScopedPrematureExitFile when file creation fails#4910
Open
hey-chocopie wants to merge 1 commit intogoogle:mainfrom
Open
Fix null pointer crash in ScopedPrematureExitFile when file creation fails#4910hey-chocopie wants to merge 1 commit intogoogle:mainfrom
hey-chocopie wants to merge 1 commit intogoogle:mainfrom
Conversation
…fails When TEST_PREMATURE_EXIT_FILE is set and posix::FOpen fails, fwrite and fclose are called on nullptr without null check. Add null check before fwrite and fclose to ignore file creation failures as intended by the existing comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fwriteandfcloseinScopedPrematureExitFileTEST_PREMATURE_EXIT_FILEpoints to invalidpath
Related Issue
Fixes #4909