Specify that Goonami only stores a hash in the crawling proto.#16
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 17, 2026
Merged
Specify that Goonami only stores a hash in the crawling proto.#16copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_869736122
branch
2 times, most recently
from
40aac28 to
8eeb25b
Compare
In Tsunami's [`eb87c7e`](google/tsunami-security-scanner@eb87c7e) we added a new field to the proto definition of a crawl. We want to be able to specify what type of information the content stores (i.e. Do we store the full content of the page? Or a hash?). Note that Tsunami on the other hand stores the full content of the page. This is because in Goonami we tracked dumping the content to file separately. PiperOrigin-RevId: 871240457
copybara-service
bot
force-pushed
the
test_869736122
branch
from
8eeb25b to
4ea086c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify that Goonami only stores a hash in the crawling proto.
In Tsunami's
eb87c7ewe added a new field to the proto definition of a crawl. We want to be able to specify what type of information the content stores (i.e. Do we store the full content of the page? Or a hash?).Note that Tsunami on the other hand stores the full content of the page. This is because in Goonami we tracked dumping the content to file separately.