Fix for issues #904 and #2144#2145
Closed
OmarAlJarrah wants to merge 2 commits intogoogle:mainfrom
OmarAlJarrah:master
Closed
Fix for issues #904 and #2144#2145OmarAlJarrah wants to merge 2 commits intogoogle:mainfrom OmarAlJarrah:master
OmarAlJarrah wants to merge 2 commits intogoogle:mainfrom
OmarAlJarrah:master
Conversation
eamonnmcmanus
requested changes
Jul 21, 2022
Member
eamonnmcmanus
left a comment
eamonnmcmanus
left a comment
There was a problem hiding this comment.
Thanks for looking into this!
| } | ||
|
|
||
| private static boolean isBigInteger(JsonPrimitive primitive) { | ||
| return primitive.value instanceof BigDecimal; |
Member
There was a problem hiding this comment.
I think this should be BigInteger? Which in turn makes me think that there should be a test that would have caught this.
Speaking of tests, in general if you are proposing a fix for an issue, you should include a test that fails without the fix and passes with it.
Author
There was a problem hiding this comment.
@eamonnmcmanus
Yes that should be a BigInteger, as for the testing part, thank you for the tip, I will make sure to provide tests with any future commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a BigDecimal is essentially a wrapper around a BigInteger that "remembers where the decimal point is", casting BigInteger to BigDecimal using the provided constructor (or the method that uses the constructor in the conversion process), and do the comparing process makes more sense, avoiding the bug of max long/double values comparison.