Run CodeQL for GitHub Actions & improve workflows#2853
Run CodeQL for GitHub Actions & improve workflows#2853eamonnmcmanus merged 4 commits intogoogle:mainfrom
Conversation
The CIFuzz workflow has been adjusted based on https://github.com/google/oss-fuzz/blob/cafd7a0eb8ecb4e007c56897996a9b65c49c972f/docs/getting-started/continuous_integration.md
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
eamonnmcmanus
left a comment
There was a problem hiding this comment.
Thanks! We'll see how this works out...
|
Thanks! It seems my change to include
Apparently the configuration name was previously implicitly generated as Maybe the warning about the not found configuration can be safely ignored. But it can possibly also be solved by deleting the configuration (the top of that page describes how to get to the list of configurations). Sorry for the inconveniences. Footnotes
|
|
OK, I've deleted the old configuration. Thanks for the detailed explanation! |
CodeQL support for GitHub Actions is now generally available, see changelog.
This pull request enables scanning of GitHub Actions and improves some of the other workflows. The CIFuzz workflow has been adjusted based on
https://github.com/google/oss-fuzz/blob/cafd7a0eb8ecb4e007c56897996a9b65c49c972f/docs/getting-started/continuous_integration.md, to also upload SARIF results (I don't know exactly how the results, if any, will be shown in the GitHub UI though).
Notes:
queries: +security-and-quality, which runs additional queries which are not run by default (see documentation)If that causes too many irrelevant alerts, we could consider changing it (either for
actionsonly, or also forjava).In that case the
codeql-analysis.ymlworkflow has to be removed and CodeQL scanning has to be enabled in the repository settings.However, 'default setup' seems to use build mode 'none' for Java, and that might not be as accurate, for example because we have the
GsonBuildConfig.javaclass which is processed during build.So maybe for now keeping the 'advanced setup' (with explicit workflow) is better?