runsc/specutils: reject host UTS namespaces#12986
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
runsc/specutils: reject host UTS namespaces#12986copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
copybara-service
Bot
force-pushed
the
test/cl903311202
branch
2 times, most recently
from
c78dca1 to
2aa5093
Compare
gVisor virtualizes UTS state, so joining an existing host UTS namespace cannot provide the expected host namespace semantics. Reject OCI specs that set a UTS namespace path during spec validation, so --uts=host fails early with a clear error. Supported behavior is unchanged for specs that create a new UTS namespace or omit the UTS namespace entry. Fixes #7995 Tested: make SHELL=/run/current-system/sw/bin/bash test TARGETS="//runsc/specutils:specutils_test" FUTURE_COPYBARA_INTEGRATE_REVIEW=#12984 from gnix0:reject-host-uts-namespace d7bcbdd PiperOrigin-RevId: 903311202
copybara-service
Bot
force-pushed
the
test/cl903311202
branch
from
2aa5093 to
4456383
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runsc/specutils: reject host UTS namespaces
gVisor virtualizes UTS state, so joining an existing host UTS namespace cannot provide the expected host namespace semantics. Reject OCI specs that set a UTS namespace path during spec validation, so --uts=host fails early with a clear error.
Supported behavior is unchanged for specs that create a new UTS namespace or omit the UTS namespace entry.
Fixes #7995
Tested:
make SHELL=/run/current-system/sw/bin/bash test TARGETS="//runsc/specutils:specutils_test"
FUTURE_COPYBARA_INTEGRATE_REVIEW=#12984 from gnix0:reject-host-uts-namespace d7bcbdd