Remove references to config stack#13366
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
copybara-service
Bot
force-pushed
the
test/cl921723888
branch
from
ed5e137 to
c63a851
Compare
The restored stack was still using the stack that was used to hold configuration, creating a kind of spit brain scenario, where the old network stack was still being used by parts of it. Also added a `poisonableClock` to the early-boot stack. This clock is poisoned immediately after restore, causing any subsequent clock/timer queries on config stack components to panic instantly, catching missed configuration cleanup bugs. PiperOrigin-RevId: 921723888
copybara-service
Bot
force-pushed
the
test/cl921723888
branch
from
c63a851 to
8ef2975
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove references to config stack
The restored stack was still using the stack that was used to hold configuration,
creating a kind of spit brain scenario, where the old network stack was still
being used by parts of it.
Also added a
poisonableClockto the early-boot stack. This clock is poisonedimmediately after restore, causing any subsequent clock/timer queries on config
stack components to panic instantly, catching missed configuration cleanup bugs.