nvproxy: don't pass privileged driver caps to nvidia-container-cli#13380
Merged
Conversation
Setting NVIDIA_DRIVER_CAPABILITIES=all with --nvproxy-allowed-driver-capabilities=all,profiling crashed runsc on startup (exit status 2): NVIDIAFlags() panicked on CapProfiling, which has no nvidia-container-cli flag. Privileged caps (CapProfiling, CapFabricIMEXManagement) are enforced internally by nvproxy, so NVIDIAFlags() now skips them instead of panicking. Adds a regression test.
copybara-service
Bot
force-pushed
the
test/cl927404806
branch
2 times, most recently
from
6312394 to
7d7e7cf
Compare
…-bug PiperOrigin-RevId: 929301493
copybara-service
Bot
force-pushed
the
test/cl927404806
branch
from
7d7e7cf to
acab33b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvproxy: don't pass privileged driver caps to
nvidia-container-cliSetting
NVIDIA_DRIVER_CAPABILITIES=allwith any of the gvisor "privileged" driver capabilities, for example--nvproxy-allowed-driver-capabilities=all,profilingcrashedrunscon startup (exit status 2):This changes how those flags are parsed by changing
NVIDIAFlags()so that "privileged" capabilities (CapProfiling,CapFabricIMEXManagement) are skipped when parsing instead of panicking. I'm also adding a regression test.FUTURE_COPYBARA_INTEGRATE_REVIEW=#13377 from luiscape:luis/nvidia-driver-capability-bug 9d6be7c