Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linalg-to-tensor-ext: plumb ciphertext-degree to linalg.matmul rewrites and distribute generic before pass #1363

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link
Contributor

@copybara-service copybara-service bot commented Feb 5, 2025

linalg-to-tensor-ext: plumb ciphertext-degree to linalg.matmul rewrites and distribute generic before pass

  1. Allow linalg-to-tensor-ext to take in the tilingSize from the ciphertext degree for now
  2. linalg-to-tensor-ext currently requires a type converter that upgrades the tensor sizes, and it currently requires (for matching) that matmuls are the single op in the generic. So distribute around matmuls in the rlwe pipelines

TODO: I just want to make sure (2) is actually required...

Part of lowering the MLP demo with loops for #1232

@copybara-service copybara-service bot force-pushed the test_723540266 branch 3 times, most recently from 99fd9de to 12a30bd Compare February 7, 2025 19:48
@asraa asraa requested a review from j2kun February 7, 2025 20:06
Copy link
Collaborator

@j2kun j2kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, though you may want to add a test in a PR next week to ensure my rework of this pass is compatible with your future needs.

@copybara-service copybara-service bot force-pushed the test_723540266 branch 3 times, most recently from 807aa36 to 6613f22 Compare February 10, 2025 18:30
@copybara-service copybara-service bot closed this Feb 10, 2025
@copybara-service copybara-service bot deleted the test_723540266 branch February 10, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant