LWE: call debug func for arguments #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asraa
approved these changes
Feb 10, 2025
|
|
||
| auto insertCall = [&](Value value) { | ||
| Type valueType = value.getType(); | ||
| if (auto lweCiphertextType = dyn_cast<NewLWECiphertextType>(valueType)) { |
There was a problem hiding this comment.
this won't work for arguments that have some shaped type of a ciphertext, right? maybe add a quick comment here, but i assume we will eventually have tensors of ciphertexts after we figure out layouts properly
There was a problem hiding this comment.
Added the comment.
asraa
added
the
pull_ready
ZenithalHourlyRate
force-pushed
the
lwe-debug-port-arg
branch
from
54ff1f9 to
9f3c71d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #1343. Added test.