Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] guide to setup a non-public repo #1395

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

WoutLegiest
Copy link
Collaborator

@WoutLegiest WoutLegiest commented Feb 11, 2025

Solve for issues #1371

@j2kun
Copy link
Collaborator

j2kun commented Feb 12, 2025

Ooh let me run through these steps myself before merging it in. I like the idea.

Copy link
Collaborator

@j2kun j2kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few suggestions to improve the reproducibility of the commands.

What do you think about putting this on a new page, maybe called "Research with HEIR" under "Development" on the sidebar? This page could also double as a place to link to research papers that use HEIR.

docs/content/en/docs/development.md Outdated Show resolved Hide resolved
docs/content/en/docs/development.md Outdated Show resolved Hide resolved
docs/content/en/docs/development.md Outdated Show resolved Hide resolved
@WoutLegiest
Copy link
Collaborator Author

LGTM! A few suggestions to improve the reproducibility of the commands.

What do you think about putting this on a new page, maybe called "Research with HEIR" under "Development" on the sidebar? This page could also double as a place to link to research papers that use HEIR.

Good idea, we can even list the bigger research questions we want to solve there

@WoutLegiest WoutLegiest force-pushed the docs_new branch 3 times, most recently from e3f7b42 to c8db5c2 Compare February 13, 2025 17:43
@WoutLegiest WoutLegiest added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Feb 13, 2025
@copybara-service copybara-service bot merged commit b237ba1 into google:main Feb 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants