Lattigo: support encoding scalar #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j2kun
approved these changes
Feb 12, 2025
j2kun
added
the
pull_ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
lattigo.bgv.encodedoes not support scalar input, which is the same as the Lattigo requirement where the API only supportsint64{}oruint64{}.However, for functions like the
foo(int a, int b), we need a way to convert the argument to tensor for the encode op.In the meantime, the
lwe.rlwe_encodetakesSignlessIntegerOrFloatLikeinput, which supports both scalar and tensor.Instead of changing the
lattigo.bgv.encodeop input type requirement, we can just add another optensor.from_elementsduring lowering.