Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support of the Hello World Small example to Arith-to-CGGI #1403

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

WoutLegiest
Copy link
Collaborator

Extending the CGGI Ops with the required operations to support the Hello World Small Example.

Updating the Arith to CGGI pass to work with these new operations, including 'deeper' checking for when an operation needs to go to CGGI and when to stay in arith.
In the Hello World Small example, some operations can stay in the arith domain. Since these constants are stored in a memref, the compiler cannot fold them away.

@WoutLegiest
Copy link
Collaborator Author

Goal is to add signed operations to the CGGI pipeline.

@WoutLegiest
Copy link
Collaborator Author

And small update to the boolean vectorizer test

lib/Dialect/CGGI/IR/CGGIOps.td Outdated Show resolved Hide resolved
lib/Dialect/Arith/Conversions/ArithToCGGI/ArithToCGGI.cpp Outdated Show resolved Hide resolved
lib/Dialect/Arith/Conversions/ArithToCGGI/ArithToCGGI.cpp Outdated Show resolved Hide resolved
@WoutLegiest WoutLegiest force-pushed the signed branch 3 times, most recently from 48141a4 to 2765be9 Compare February 13, 2025 21:35
@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Feb 14, 2025
@copybara-service copybara-service bot merged commit fae5e95 into google:main Feb 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants