Remove brush behavior sources measured in milliseconds#503
Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
Closed
Remove brush behavior sources measured in milliseconds#503copybara-service[bot] wants to merge 0 commit intomainfrom
copybara-service[bot] wants to merge 0 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_869222967
branch
3 times, most recently
from
29ba08e to
42dbd42
Compare
copybara-service
bot
force-pushed
the
test_869222967
branch
from
42dbd42 to
0cfa68b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove brush behavior sources measured in milliseconds
These are redundant with the equivalent sources that are measured in seconds, since you can always just scale the source value range bounds. We don't need both, for the same reason that we don't have e.g.
kTiltInDegreesin addition tokTiltInRadians.For now, the
*_IN_MILLISproto enum values have been retained (and marked deprecated), and the proto decoder will scale the source range to the "in seconds" version as necessary.