Associate versions to features in BrushFamily proto.#510
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Associate versions to features in BrushFamily proto.#510copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_872916637
branch
from
412ed64 to
b656e34
Compare
copybara-service
bot
changed the title
transitive_descriptor_set and options_cc_proto will be used in a future CL.
copybara-service
bot
force-pushed
the
test_872916637
branch
from
b656e34 to
0b3ef3e
Compare
Add descriptors to associate ink.proto.Version values with messages, fields, and enum types in BrushFamily proto. This will be used in a future CL to write consistency tests to ensure all features have a minimum compatible version associated with them. `transitive_descriptor_set` and `options_cc_proto` will be used in a future CL. Version `1.0.0` (stable 1) is being used to represent all the features that were available when Ink `1.0.0` was released (TODO: I think I have this right here, but where can I find the last commit on the C++ side that was included to confirm this?). Everything else is being lumped under the (presumed) next release of Ink, Version `1.1.0-alpha01` (if features get cut or pushed off, we can change them). We don't necessarily need this split, as there is no release of Ink which has versioning set with a maximum allowed version of `1.0.0`, so the actual `1.0.0` release will not reject brushes from `1.1.0-alpha01`. But, this distinction in the code now has been useful for testing purposes. PiperOrigin-RevId: 872916637
copybara-service
bot
force-pushed
the
test_872916637
branch
from
0b3ef3e to
b740a3d
Compare
copybara-service
bot
changed the title
transitive_descriptor_set and options_cc_proto will be used in a future CL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associate versions to features in BrushFamily proto.
Add descriptors to associate ink.proto.Version values with messages, fields, and enum types in BrushFamily proto. This will be used in a future CL to write consistency tests to ensure all features have a minimum compatible version associated with them.
transitive_descriptor_setandoptions_cc_protowill be used in a future CL.Version
1.0.0(stable 1) is being used to represent all the features that were available when Ink1.0.0was released (TODO: I think I have this right here, but where can I find the last commit on the C++ side that was included to confirm this?). Everything else is being lumped under the (presumed) next release of Ink, Version1.1.0-alpha01(if features get cut or pushed off, we can change them). We don't necessarily need this split, as there is no release of Ink which has versioning set with a maximum allowed version of1.0.0, so the actual1.0.0release will not reject brushes from1.1.0-alpha01. But, this distinction in the code now has been useful for testing purposes.